Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed lease not showing pids on view #3824

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Fixed lease not showing pids on view #3824

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
825c4bf
Fixed lease not showing pids on view
FuriousLlama Feb 28, 2024
7b8fc1d
Merge branch 'dev' into bugs/psp-7901
FuriousLlama Feb 28, 2024
263e09e
Merge branch 'dev' into bugs/psp-7901
FuriousLlama Feb 29, 2024
b5c5a7d
Merge branch 'dev' into bugs/psp-7901
FuriousLlama Feb 29, 2024
f707389
Merge branch 'dev' into bugs/psp-7901
FuriousLlama Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source/frontend/src/features/leases/detail/LeasePages/details/PropertyInformation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Input } from '@/components/common/form';
import { SectionField } from '@/components/common/Section/SectionField';
import { ApiGen_Base_CodeType } from '@/models/api/generated/ApiGen_Base_CodeType';
import { ApiGen_Concepts_Lease } from '@/models/api/generated/ApiGen_Concepts_Lease';
import { formatNumber, isValidString, pidFormatter } from '@/utils';
import { formatNumber, isValidId, isValidString, pidFormatter } from '@/utils';
import { withNameSpace } from '@/utils/formUtils';

import AddressSubForm from '../AddressSubForm';
Expand All @@ -33,13 +33,13 @@ export const PropertyInformation: React.FunctionComponent<
withNameSpace(nameSpace, 'areaUnitType'),
);

const legalDescription = getIn(
const legalDescription: string = getIn(
formikProps.values,
withNameSpace(nameSpace, 'property.landLegalDescription'),
);
const pid = getIn(formikProps.values, withNameSpace(nameSpace, 'property.pid'));
const pid: number | null = getIn(formikProps.values, withNameSpace(nameSpace, 'property.pid'));

const pidText = pid ? `PID: ${pidFormatter(pid)}` : '';
const pidText = isValidId(pid) ? `PID: ${pidFormatter(pid.toString())}` : '';
return (
<StyledPropertyInfo>
<SectionField label="PID" labelWidth="3">
Expand Down
Loading