psp-7590 - update moti highway/region layer to internal. Allow for so… #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
asanchezr
reviewed
Jun 5, 2024
Comment on lines
+27
to
+28
| "motiRegionLayerUrl": "https://maps.th.gov.bc.ca/geoV05/wfs?SERVICE=WFS&REQUEST=GetFeature&VERSION=1.3.0&outputFormat=application/json&typeNames=hwy:DSA_REGION_BOUNDARY", | ||
| "hwyDistrictLayerUrl": "https://maps.th.gov.bc.ca/geoV05/wfs?SERVICE=WFS&REQUEST=GetFeature&VERSION=1.3.0&outputFormat=application/json&typeNames=hwy:DSA_DISTRICT_BOUNDARY", |
There was a problem hiding this comment.
does this mean that now we are required to be on VPN while developing locally against those layers?
There was a problem hiding this comment.
No, msw will handle any requests to those layers (see update to handlers).
asanchezr
reviewed
Jun 5, 2024
Comment on lines
80
to
82
| <StyledSmallText> | ||
| <b>{preText}</b> | ||
| </StyledSmallText> |
There was a problem hiding this comment.
I recall this change from another PR - please rebase your branch
asanchezr
approved these changes
Jun 7, 2024
…me dev overrides.
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me dev overrides.