PSP-7930 : Generate Document Hyperlink located within L/L File Summar…

[eddherrera]

…y Pane - H1005

[github-actions]

✅ No secrets were detected in the code.

[github-actions]

✅ No secrets were detected in the code.

[github-actions]

✅ No secrets were detected in the code.

[devinleighsmith]

When you merge this, you will need to run the alter down in dev, and then the alter up. Feel free to ask for help if you aren't confident with this.

[devinleighsmith]

Hmm, I feel like this will crash if a document has been uploaded with the H1005 form type code - probably need to clear that first before executing this.

[eddherrera]

the script file is duplicated I'll delete it.

[devinleighsmith]

no toString here but there is above?

[eddherrera]

I could make the update to match, either way is fin and do cast to string.

[devinleighsmith]

This story cannot be merged until a valid template is merged to https://confluence.th.gov.bc.ca/display/PIMS/Release+5.4

[eddherrera]

This story cannot be merged until a valid template is merged to https://confluence.th.gov.bc.ca/display/PIMS/Release+5.4

Page updated with template.

[github-actions]

✅ No secrets were detected in the code.

[github-actions]

✅ No secrets were detected in the code.

[devinleighsmith]

This is what I get back from my test:

this normally happens when the carbone template is invalid in some way, or the data being passed doesn't match the expected format

Here is my test json:

{ "templateType": "H1005", "templateData": { "file_number": "100207435", "commencement_date": "September 30, 2006", "land_string": "Parcel Identifier: 014-341-239\n\n0 Meters sq\n\nParcel Identifier: 012-909-581\n\n0 Meters sq\n\nParcel Identifier: 010-308-610\n\n0 Meters sq\n\nParcel Identifier: 009-659-790\n\n0 Meters sq", "intended_use": "", "term_end_date": "", "payment_amount": "$0.00", "payment_due_date": "", "security_amount": "$2,000.00", "cgl_limit": "$0.00", "marine_liability_limit": "$0.00", "vehicle_liability_limit": "$0.00", "aircraft_liability_limit": "$0.00", "deposits": [ { "security_amount": "$2,000.00" } ], "tenants": [], "person_tenants": [], "organization_tenants": [], "lease_properties": [ { "lease_area": "", "property": { "location": { "coordinate": { "x": -123.11016942780061, "y": 49.190648254589576 } }, "pid": "014-341-239", "legal_desc": "", "region": "", "address": { "line_1": "45 - 904 Hollywood Crescent", "line_2": "Living in a van", "line_3": "Down by the River", "city": "Hollywood North", "province": "", "postal": "V6Z 5G7", "country": "", "address_string": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North\nV6Z 5G7", "address_string_multiline_compressed": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North, V6Z 5G7", "address_single_line_string": "45 - 904 Hollywood Crescent, Living in a van, Down by the River, Hollywood North, V6Z 5G7" }, "location_of_land": "", "district": "", "electoral_dist": "" } }, { "lease_area": "", "property": { "location": { "coordinate": { "x": -130.0138780944279, "y": 55.91341667778342 } }, "pid": "012-909-581", "legal_desc": "", "region": "", "address": { "line_1": "45 - 904 Hollywood Crescent", "line_2": "Living in a van", "line_3": "Down by the River", "city": "Hollywood North", "province": "", "postal": "V6Z 5G7", "country": "", "address_string": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North\nV6Z 5G7", "address_string_multiline_compressed": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North, V6Z 5G7", "address_single_line_string": "45 - 904 Hollywood Crescent, Living in a van, Down by the River, Hollywood North, V6Z 5G7" }, "location_of_land": "", "district": "", "electoral_dist": "" } }, { "lease_area": "", "property": { "location": { "coordinate": { "x": -122.42949439143196, "y": 52.504094004547866 } }, "pid": "010-308-610", "legal_desc": "", "region": "", "address": { "line_1": "45 - 904 Hollywood Crescent", "line_2": "Living in a van", "line_3": "Down by the River", "city": "Hollywood North", "province": "", "postal": "V6Z 5G7", "country": "", "address_string": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North\nV6Z 5G7", "address_string_multiline_compressed": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North, V6Z 5G7", "address_single_line_string": "45 - 904 Hollywood Crescent, Living in a van, Down by the River, Hollywood North, V6Z 5G7" }, "location_of_land": "", "district": "", "electoral_dist": "" } }, { "lease_area": "", "property": { "location": { "coordinate": { "x": -120.13052458243057, "y": 51.17453565347547 } }, "pid": "009-659-790", "legal_desc": "", "region": "", "address": { "line_1": "45 - 904 Hollywood Crescent", "line_2": "Living in a van", "line_3": "Down by the River", "city": "Hollywood North", "province": "", "postal": "V6Z 5G7", "country": "", "address_string": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North\nV6Z 5G7", "address_string_multiline_compressed": "45 - 904 Hollywood Crescent\nLiving in a van\nDown by the River\nHollywood North, V6Z 5G7", "address_single_line_string": "45 - 904 Hollywood Crescent, Living in a van, Down by the River, Hollywood North, V6Z 5G7" }, "location_of_land": "", "district": "", "electoral_dist": "" } } ] }, "convertToType": null }

[github-actions]

✅ No secrets were detected in the code.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.01%. Comparing base (3353581) to head (02c6d0c).

Additional details and impacted files

@@             Coverage Diff             @@
##              dev    #4091       +/-   ##
===========================================
- Coverage   85.40%   77.01%    -8.40%     
===========================================
  Files        1621      493     -1128     
  Lines      122460    18052   -104408     
  Branches     9386     1238     -8148     
===========================================
- Hits       104593    13903    -90690     
+ Misses      17561     3843    -13718     
  Partials      306      306               

Flag	Coverage Δ
unittests	77.01% <ø> (-8.40%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../backend/api/Services/DocumentGenerationService.cs	0.00% <ø> (ø)

... and 1127 files with indirect coverage changes