Update pims health checks to support configuration based enable/disab… #4099
Conversation
devinleighsmith
added
enhancement
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-8631
branch
from
9e99278
to
5a651bc
Compare
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
| if (allHealthCheckOptions.ApiMetrics.Enabled) | ||
| { | ||
| services.AddHealthChecks().Add(new HealthCheckRegistration( | ||
| "ApiMetrics", |
There was a problem hiding this comment.
I believe we use the string "api-metrics" in our Prometheus/Sysdig dashboards. We will need to update the dashboards to read from the new "ApiMetrics" information or they will show no data...
There was a problem hiding this comment.
NVM - I checked Sysdig and we don't use that name at all - disregard previous comment.
source/backend/api/appsettings.json
Outdated
| "Enabled": true, | ||
| "Duration": 1 |
There was a problem hiding this comment.
I see a discrepancy here in regards to the duration/period. In other configuration files I see the override values as "Period" vs here they are set originally as "Duration". I think you need to pick one...
Perhaps rename these ones as Period?
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
…le and period.