Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-8566 : FT: Lease & Licences - Tenants: Select Tenants button gets… #4109

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

eddherrera
Copy link
Collaborator

… blue after clicking on it.

@eddherrera eddherrera added the bug Something isn't working label Jun 12, 2024
@eddherrera eddherrera self-assigned this Jun 12, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

@@ -19,7 +19,10 @@ export const SectionListHeader: React.FunctionComponent<
React.PropsWithChildren<ISectionListHeaderProps>
> = props => {
const { hasClaim } = useKeycloakWrapper();
const onClick = () => props.onAdd && props.onAdd();
const onClick = (e): void => {
Copy link
Collaborator

@devinleighsmith devinleighsmith Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddherrera I think this bug is a styling issue (CSS) not a functionality issue (JS).

try something like this in the styles.ts for the add button:

export const StyledAddButton = styled(Button)
  &.btn.btn-primary {
    background-color: ${props => props.theme.bcTokens.iconsColorSuccess};
  }
  &.btn.btn-primary:active,
  &.btn.btn-primary:focus {
    background-color: ${props => props.theme.bcTokens.iconsColorSuccess};
    outline-color: ${props => props.theme.css.pimsGreen80};
  }
  &.btn.btn-primary:hover {
    background-color: ${props => props.theme.css.pimsGreen80};
  }
;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devinleighsmith not so sure about this one. The styling definitions are as expected. This is a well-known issue with many workarounds. Either bootstrap or react is not resetting the button state.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is this an issue with other buttons? I think the problem here is that a green button turns blue, not that it goes into some kind of "clicked" state that isn't reset properly.

Copy link
Collaborator Author

@eddherrera eddherrera Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with reporter the issue is setting the focus to last active element after modal is closed. Which is a bootstrap modal option. So I am turning it off.

Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit f32b906 into bcgov:dev Jun 17, 2024
7 checks passed
@eddherrera eddherrera deleted the psp-8566 branch July 31, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants