Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7498: UI/UX Clean Up - Contacts - View #4111

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Conversation

stairaku
Copy link
Collaborator

No description provided.

@stairaku stairaku added enhancement New feature or request frontend labels Jun 13, 2024
@stairaku stairaku self-assigned this Jun 13, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

@stairaku stairaku added the 5.4 label Jun 14, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith
Copy link
Collaborator

Some minor areas where the mockup doesn't seem to match the implementation, have these been approved by Ana? if so, they need to be updated in the mockup or this will fail FT:

image

@devinleighsmith
Copy link
Collaborator

Also some issues here: corporation vs incorporation. missing tooltip:

image

@devinleighsmith
Copy link
Collaborator

Please check with ana on whether the incorporation number should be required as labelled on the mockup:

image

@devinleighsmith
Copy link
Collaborator

See this: organization section doesn't exist in edit mockup:

image

Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work with Ana to close gap in differences between mockups and implementation.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

✅ No secrets were detected in the code.

@stairaku
Copy link
Collaborator Author

I have updated the forms for View and Update for both Personal and Organization contacts accordingly to comments and discussed with Ana which changes she needs to be done on her end. She confirmed she needs to update these mockups since last time they were updated were on November 2023.

The new status look and feel are not currently on the mockup but the details are attached on the JIRA ticket as a comment.

Attaching current forms for approval:
image
image
image
image

Copy link
Contributor

✅ No secrets were detected in the code.

@stairaku stairaku merged commit ac178ca into bcgov:dev Jun 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.4 enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants