Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psp-7862 collapse map side bar #4116

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Psp-7862 collapse map side bar #4116

merged 4 commits into from
Jun 25, 2024

Conversation

devinleighsmith
Copy link
Collaborator

image

image

@devinleighsmith devinleighsmith self-assigned this Jun 14, 2024
@devinleighsmith devinleighsmith added 5.4 enhancement New feature or request labels Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith changed the title Psp 7862 Psp-7862 collapse map side bar Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.48019% with 58 lines in your changes missing coverage. Please review.

Project coverage is 86.87%. Comparing base (5997d17) to head (6714d41).

❗ Current head 6714d41 differs from pull request most recent head b7cd214

Please upload reports for the commit b7cd214 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4116      +/-   ##
==========================================
+ Coverage   85.49%   86.87%   +1.37%     
==========================================
  Files        1622     1129     -493     
  Lines      122851   104621   -18230     
  Branches     9483     8174    -1309     
==========================================
- Hits       105029    90886   -14143     
+ Misses      17513    13735    -3778     
+ Partials      309        0     -309
Flag Coverage Δ
unittests 86.87% <86.48%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../frontend/src/components/common/buttons/Button.tsx 97.11% <100.00%> (ø)
...components/common/buttons/ExpandCollapseButton.tsx 100.00% <100.00%> (ø)
...omponents/common/mapFSM/machineDefinition/types.ts 100.00% <100.00%> (ø)
source/frontend/src/components/common/styles.ts 99.46% <100.00%> (+0.02%) ⬆️
...nd/src/components/layout/SideNavBar/SideNavbar.tsx 100.00% <100.00%> (ø)
...rontend/src/components/layout/SideNavBar/styles.ts 100.00% <100.00%> (ø)
...ponents/maps/leaflet/LayerPopup/LayerPopupView.tsx 91.16% <100.00%> (+0.04%) ⬆️
...rce/frontend/src/components/maps/leaflet/styles.ts 100.00% <100.00%> (ø)
...tend/src/features/leases/add/AddLeaseContainer.tsx 91.11% <100.00%> (ø)
...etail/LeasePages/payment/TermPaymentsContainer.tsx 93.04% <100.00%> (-4.51%) ⬇️
... and 30 more

... and 547 files with indirect coverage changes

@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

asanchezr
asanchezr reviewed Jun 19, 2024
View reviewed changes
source/frontend/src/components/common/buttons/ExpandCollapseButton.tsx
Comment on lines +15 to +18
/**
* PlusButton displaying a plus button, used to add new items.
* @param param0
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wrong component name

asanchezr
asanchezr reviewed Jun 24, 2024
View reviewed changes
source/frontend/src/features/mapSideBar/research/ResearchView.tsx
@@ -79,7 +79,7 @@ const ResearchView: React.FunctionComponent<IResearchViewProps> = props => {
return (
<MapSideBarLayout
title={props.isEditing ? 'Update Research File' : 'Research File'}
icon={<MdTopic title="User Profile" size="2.5rem" className="mr-2" />}
icon={<MdTopic title="User Profile" size="2.5rem" />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: all other icons are sized at 2.6 rem - would it make sense to adjust this one too?

asanchezr
asanchezr reviewed Jun 24, 2024
View reviewed changes
source/frontend/src/features/mapSideBar/research/add/AddResearchContainer.tsx
@@ -199,7 +199,7 @@ export const AddResearchContainer: React.FunctionComponent<IAddResearchContainer
{formikProps => (
<MapSideBarLayout
title="Create Research File"
icon={<MdTopic title="User Profile" size="2.5rem" className="mr-2" />}
icon={<MdTopic title="User Profile" size="2.5rem" />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: all other icons are sized at 2.6 rem - would it make sense to adjust this one too?

@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit 858e42e into bcgov:dev Jun 25, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Open
@devinleighsmith devinleighsmith mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanchezr asanchezr asanchezr approved these changes

Assignees

@devinleighsmith devinleighsmith

Labels
5.4 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinleighsmith @asanchezr