IS83 scaffold changes, also includes many renames from term to period. #4136
Conversation
|
✅ No secrets were detected in the code. |
| @@ -64,7 +64,7 @@ public IActionResult AddPayment(long leaseId, [FromBody] PaymentModel paymentMod | |||
| { | |||
| _logger.LogInformation( | |||
| "Request received by Controller: {Controller}, Action: {ControllerAction}, User: {User}, DateTime: {DateTime}", | |||
| nameof(LeaseTermController), | |||
| nameof(LeasePeriodController), | |||
There was a problem hiding this comment.
this should actually be LeasePaymentController - probably a copy/paste mistake on prior PRs
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4136 +/- ##
==========================================
- Coverage 85.48% 85.41% -0.08%
==========================================
Files 1623 1623
Lines 123009 122968 -41
Branches 9494 9485 -9
==========================================
- Hits 105153 105030 -123
- Misses 17547 17629 +82
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -89,7 +89,7 @@ public IActionResult UpdatePayment(long leaseId, long paymentId, [FromBody] Paym | |||
| { | |||
| _logger.LogInformation( | |||
| "Request received by Controller: {Controller}, Action: {ControllerAction}, User: {User}, DateTime: {DateTime}", | |||
| nameof(LeaseTermController), | |||
| nameof(LeasePeriodController), | |||
There was a problem hiding this comment.
sorry, these need to be changed as well
| @@ -114,7 +114,7 @@ public IActionResult DeletePayment(long leaseId, PaymentModel paymentModel) | |||
| { | |||
| _logger.LogInformation( | |||
| "Request received by Controller: {Controller}, Action: {ControllerAction}, User: {User}, DateTime: {DateTime}", | |||
| nameof(LeaseTermController), | |||
| nameof(LeasePeriodController), | |||
There was a problem hiding this comment.
sorry, these need to be changed as well
|
✅ No secrets were detected in the code. |
| @@ -22,7 +22,7 @@ export const LeaseViewPageForm: React.FunctionComponent< | |||
| > = ({ children, leasePageName, isEditing, onEdit }) => { | |||
| const { lease } = useContext(LeaseStateContext); | |||
|
|
|||
| const DisplayLeaseTerminationMessage = () => { | |||
| const DisplayLeasePeriodinationMessage = () => { | |||
There was a problem hiding this comment.
nit: DisplayLeasePeriodinationMessage -> DisplayLeaseTerminationMessage
| onCancel: () => void; | ||
| onSave: (values: FormLeasePayment) => void; | ||
| } | ||
|
|
||
| /** | ||
| * Modal displaying form allowing add/update lease terms. Save button triggers internal formik validation and submit. | ||
| * Modal displaying form allowing add/update lease peridos. Save button triggers internal formik validation and submit. |
There was a problem hiding this comment.
typo: peridos -> periods
|
✅ No secrets were detected in the code. |
No description provided.