psp-8780 scaffold of IS84 #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
asanchezr
reviewed
Jul 4, 2024
Comment on lines
-53
to
-56
| [Column("DESCRIPTION")] | ||
| [StringLength(2000)] | ||
| public string Description { get; set; } | ||
|
|
There was a problem hiding this comment.
I know this is auto-generated but wanted to double check that it makes sense to drop this column in the history table while keeping the original in the PimsPropertyActivity table...
There was a problem hiding this comment.
Good catch. We can leave things in the hist table that are being removed from the original table but not the other way around
There was a problem hiding this comment.
Also, if we are removing a column that never saw the light of prod, then removing it from hist makes sense
asanchezr
approved these changes
Jul 4, 2024
|
✅ No secrets were detected in the code. |
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.