Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-8693: Rename Header Dates (Lease and License) #4172

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

asanchezr
Copy link
Collaborator

image

@asanchezr asanchezr added enhancement New feature or request 5.4 labels Jul 9, 2024
@asanchezr asanchezr self-assigned this Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

✅ No secrets were detected in the code.

Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have some issues coming back from FT on the mockup vs implementation
Current expiry(mockup) vs. Expiry(implementation)
File: (implementation) vs. (mockup)

@asanchezr
Copy link
Collaborator Author

You may have some issues coming back from FT on the mockup vs implementation Current expiry(mockup) vs. Expiry(implementation) File: (implementation) vs. (mockup)

Appreciate the feedback. I went with what was described in Confluence. We will need to sync up the mockup and Confluence when Ana is back

@asanchezr asanchezr force-pushed the psp-8693-lease-header-dates branch from cc3995a to dbfcde8 Compare July 9, 2024 23:04
Copy link
Contributor

github-actions bot commented Jul 9, 2024

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 6eada7c into bcgov:dev Jul 9, 2024
7 checks passed
@asanchezr asanchezr deleted the psp-8693-lease-header-dates branch July 9, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.4 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants