PSP-7980 : Display L/L Status in Property Information Pane - Management (Summary Section) #4188
Conversation
eddherrera
commented
Jul 11, 2024
eddherrera
commented
…nt (Summary Section)
|
✅ No secrets were detected in the code. |
| hasActiveExpiryDate = false; | ||
|
|
||
| List<PimsLease> activeAgreementsList = propertyLeases.Select(x => x.Lease).ToList(); | ||
| var activeLease = activeAgreementsList.FirstOrDefault(x => x.LeaseStatusTypeCode == LeaseStatusTypes.ACTIVE.ToString()); |
There was a problem hiding this comment.
My understanding of the requirements, is that if there is any lease that is active for a property, that should be displayed on the management screen.
Given that a single property may have multiple leases (ie, a large lot with many buildings). it seems entirely possible that a single property may have multiple active leases, where some of those active leases may have expired or been terminated.
as a result, I think using FirstOrDefault here doesn't work.
There was a problem hiding this comment.
Updated to check for other leases with a loop.
| } | ||
| else | ||
| { | ||
| var latestRemewal = activeLease.PimsLeaseRenewals.Where(x => x.IsExercised.HasValue && x.IsExercised.Value).OrderByDescending(x => x.CommencementDt).FirstOrDefault(); |
There was a problem hiding this comment.
nit latestRemewal -> latestRenewal
There was a problem hiding this comment.
FYI a fast way of checking if a nullable boolean is a specific value is just x.IsExercised == true, since null != true and false != true
| var latestRemewal = activeLease.PimsLeaseRenewals.Where(x => x.IsExercised.HasValue && x.IsExercised.Value).OrderByDescending(x => x.CommencementDt).FirstOrDefault(); | ||
| if (latestRemewal is null) // No Renewal - Check only Lease dates. | ||
| { | ||
| if(activeLease.OrigExpiryDate.HasValue && activeLease.OrigExpiryDate.Value.Date >= DateTime.UtcNow.Date) |
There was a problem hiding this comment.
I think this is an example of when you don't want to use the UTC date. If you did, and a user used this logic before 7am, the utc date would not match the pst date.
There was a problem hiding this comment.
Another way to think of this - when we store dates with times, we store them in UTC. When we store dates only, we store them as-is.
There was a problem hiding this comment.
Please note that this is backend (C#) code so this runs in the timezone of the .NET container - which by default is UTC in docker/openshift. I'm not aware that we set the timezone to PST on our live env containers.
If we want to do this "Date math" in PST we need to do that manually (either subtract 7hrs from UTC or convert the exp date to UTC)
| } | ||
| else if(activeLease.OrigExpiryDate.HasValue && !latestRemewal.ExpiryDt.HasValue) | ||
| { | ||
| hasActiveLease = true; |
There was a problem hiding this comment.
wouldn't this also mean that the lease has an active expiry date? Or if not, is this even possible for exercised agreements?
There was a problem hiding this comment.
not quite sue, I am trying to cover for the scenarios not documented in the AC.
| } | ||
| else if (!activeLease.OrigExpiryDate.HasValue && latestRemewal.ExpiryDt.HasValue) | ||
| { | ||
| hasActiveLease = latestRemewal.ExpiryDt.Value.Date >= DateTime.UtcNow.Date; |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
