Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-8744 : Management activity - tooltip for Delete #4190

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

eddherrera
Copy link
Collaborator

image

@eddherrera eddherrera added the enhancement New feature or request label Jul 12, 2024
@eddherrera eddherrera self-assigned this Jul 12, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

@@ -15,12 +15,13 @@ export interface IPropertyActivityEditContainerProps {
propertyId: number;
propertyActivityId?: number;
onClose: () => void;
viewEnabled: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some documentation for this prop please.

@@ -11,12 +11,13 @@ export interface IPropertyActivityDetailContainerProps {
propertyId: number;
propertyActivityId: number;
onClose: () => void;
viewEnabled: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc here as well.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 054de6f into bcgov:dev Jul 15, 2024
7 checks passed
@eddherrera eddherrera deleted the psp-8744 branch July 31, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants