psp-8018: display retired warning immediately upon add. #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
| properties: { | ||
| STREET_ADDRESS_1: addressResults[i]?.fullAddress, | ||
| }, | ||
| } as Feature<Geometry, PIMS_Property_Location_View>); |
There was a problem hiding this comment.
This casting is smelly
There was a problem hiding this comment.
This isn't one of my changes, so I'll leave it as-is.
FuriousLlama
approved these changes
Jul 15, 2024
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
asanchezr
reviewed
Jul 15, 2024
Comment on lines
+61
to
+67
| const queryObject = {}; | ||
| if (pid.length > 0) { | ||
| queryObject['PID'] = pid; | ||
| } | ||
| if (isValidId(+pin)) { | ||
| queryObject['PIN'] = pin; | ||
| } |
There was a problem hiding this comment.
Could you please comment what we want to do with this queryObject? It seems it gets created but not used anywhere. Perhaps it is meant to be used in the line below (line 68)?
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
|
@devinleighsmith - please update snapshots |
devinleighsmith
force-pushed
the
psp-8018
branch
from
0c0558f
to
08b16f5
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-8018
branch
from
08b16f5
to
13f2bb0
Compare
|
✅ No secrets were detected in the code. |
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.