Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP-9152 : Expand documents tab to improve readability #4356

Merged
merged 2 commits into from
Sep 20, 2024
Merged

PSP-9152 : Expand documents tab to improve readability #4356

merged 2 commits into from
Sep 20, 2024

Conversation

eddherrera
Copy link
Collaborator

@eddherrera eddherrera commented Sep 20, 2024 •
edited
Loading

image

@eddherrera eddherrera added the enhancement New feature or request label Sep 20, 2024
@eddherrera eddherrera self-assigned this Sep 20, 2024
asanchezr
asanchezr approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@asanchezr asanchezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but would have loved to see unit tests added that assert that mapMachine.setFullWidthSidebar has been called when switching to the relevant tabs

@asanchezr asanchezr merged commit d167922 into bcgov:dev Sep 20, 2024
7 checks passed
@eddherrera eddherrera deleted the psp-9152 branch September 23, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanchezr asanchezr asanchezr approved these changes

@devinleighsmith devinleighsmith Awaiting requested review from devinleighsmith

Assignees

@eddherrera eddherrera

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddherrera @asanchezr