Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psp-9316 correct stream route url, axios fileType. (#4388) #4397

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.47%. Comparing base (5588731) to head (d525f8f).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...rce/frontend/src/hooks/pims-api/useApiDocuments.ts 0.00% 6 Missing ⚠️
...cuments/documentDetail/DocumentDetailContainer.tsx 0.00% 2 Missing ⚠️
...rc/features/documents/DocumentPreviewContainer.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4397      +/-   ##
==========================================
- Coverage   87.20%   85.47%   -1.73%     
==========================================
  Files        1164     1669     +505     
  Lines      118043   136979   +18936     
  Branches     8747    10066    +1319     
==========================================
+ Hits       102937   117086   +14149     
- Misses      15106    19550    +4444     
- Partials        0      343     +343     
Flag Coverage Δ
unittests 85.47% <25.00%> (-1.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/features/documents/DownloadDocumentButton.tsx 55.38% <100.00%> (ø)
...rc/features/documents/DocumentPreviewContainer.tsx 97.70% <66.66%> (+1.11%) ⬆️
...cuments/documentDetail/DocumentDetailContainer.tsx 16.57% <0.00%> (+0.09%) ⬆️
...rce/frontend/src/hooks/pims-api/useApiDocuments.ts 61.70% <0.00%> (-1.81%) ⬇️

... and 504 files with indirect coverage changes

@devinleighsmith devinleighsmith merged commit 647a6a3 into master Oct 16, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants