Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1734 registration2 ci cd #1758

Merged
merged 30 commits into from
Jun 28, 2024
Merged

1734 registration2 ci cd #1758

merged 30 commits into from
Jun 28, 2024

Conversation

marcellmueller
Copy link
Contributor

@marcellmueller marcellmueller commented Jun 6, 2024

Implements #1734

  • Adds Dockerfile to /bciers/registration. I added some updates from fix: docker build issues #1856 and Sonarcloud is flagging the chown commands for Make sure no write permissions are assigned to the executable. which needs review
  • Builds the dockerfile and pushes it to GHCR
  • Added a helm chart though Josh is going to get this all working in OpenShift in another PR he is working on with the multizone auth stuff.

This can't be merged without updating the branch protections first. As you can see at the bottom of this PR, renaming the jobs broke required status protection and they are all stuck on Expected — Waiting for status to be reported.

This also includes a pretty hefty reorganization of our GitHub Actions pipeline. Most of our jobs including our build steps were in test.yaml and it was getting rather large and needed to be split up. This will just be part 1 of our pipeline reorganization and a good starting base to break up jobs and optimize CI going forward.

  • Added a main.yaml which orchestrates all workflows
  • Moved docker image builds to their own files and call them in main.yaml
  • Added run-backend action. Currently the backend test starts up the entire app including the front end which is unnecessary.
  • Created a reusable action called nx-app-build that builds and pushes a docker image for our nx projects with just a few env vars/inputs. The backend docker build was different enough and is unique so it stays the same.
  • Trigger the Trivy and CodeQL workflows from main.yaml so we don't see separate actions for each push when clicking the Actions tab which was always confusing when trying to debug issues through prior workflows. Now they appear as a job in the main workflow.
  • test-code.yaml is for tests that don't require containers to be built first and can run immediately.
  • Moved e2e tests to test-e2e.yaml which can be called when the backend image and registration1 image is built. We can add more required jobs for registration and reporting as we set up e2e for those projects.

@marcellmueller marcellmueller force-pushed the 1734-registration2-ci-cd branch 30 times, most recently from 3b5c1ad to 81b1498 Compare June 10, 2024 15:00
@marcellmueller marcellmueller merged commit 5569f1e into develop Jun 28, 2024
23 checks passed
@marcellmueller marcellmueller deleted the 1734-registration2-ci-cd branch June 28, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants