1862 - refine multi zone routing #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellmueller
changed the title
marcellmueller
force-pushed
the
1862-refine-multi-zone-routing
branch
2 times, most recently
from
9c5318e
to
075e862
Compare
marcellmueller
commented
Jun 28, 2024
| import { NextURL } from "next/dist/server/web/next-url"; | ||
| import { NextFetchEvent, NextRequest, NextResponse } from "next/server"; | ||
| import { instance, mock, reset, when } from "ts-mockito"; | ||
| import middleware from "../middleware"; |
There was a problem hiding this comment.
Technically this is testing bciers/apps/dashboard/middleware.ts though this currently is the only middleware and all the tests are about this so I thought this made more sense. Also I wasn't sure how to just test this withAuthorization function on its own but found examples online of how to test the NextJS middleware stack.
marcellmueller
force-pushed
the
1862-refine-multi-zone-routing
branch
3 times, most recently
from
93b9367
to
601e587
Compare
4 tasks
| email?: string; | ||
| phone_number?: string; | ||
| app_role?: { role_name: string }; | ||
| } |
There was a problem hiding this comment.
I don't see why we need the UserProfileFormData and UserProfilePartialFormData interfaces defined again here when they're already defined in bciers/libs/shared/types/src/form/formData.ts ?
There was a problem hiding this comment.
Thanks, fixed!
marcellmueller
force-pushed
the
1862-refine-multi-zone-routing
branch
2 times, most recently
from
77f04da
to
e91fd90
Compare
andrea-williams
approved these changes
Jul 3, 2024
marcellmueller
force-pushed
the
1862-refine-multi-zone-routing
branch
2 times, most recently
from
155554b
to
9a45e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to bring in some updates from #1862 that weren't brought in with #1867
View #1867 for some more context on this though what I've brought in this PR:
withAuthorizationmiddlewaresactionsproject, update imports