Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/generate report #127

Merged
merged 135 commits into from
Dec 21, 2023
Merged

Feature/generate report #127

merged 135 commits into from
Dec 21, 2023

Conversation

banders
Copy link
Contributor

@banders banders commented Dec 20, 2023

Description

Incremental improvements to the report, including:

  • fixed the bonus pay graphs (previously we showed the overtime pay in the bonus pay area)
  • changes to how bar chart colors are handled to prepare for showing charts with some data suppressed (although we don't yet fully handle suppressed data)
  • for most calculations, multiply by 100 to get a percentage. save the percentage to the database.
  • updated the overtime hours calculations so that negative numbers mean the group works less than the reference group.
  • included "user comments" at the top of the report
  • changed frontend input form submission to send empty strings instead of nulls for user_comments and data_constraints (because in multipart/formdata requests, nulls are converted to strings that say "null")

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking changes which fix several issues)

How Has This Been Tested?

Updated existing unit tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:


Thanks for the PR!

Deployments, as required, will be available below:


Thanks for the PR!

Deployments, as required, will be available below:

banders and others added 30 commits December 7, 2023 14:13
…le gender codes per gender category. added a new method to standardize a given gender code (so it can be treated the same as other codes which refer to the same gender)
…ll adjustments to the _report table. added a new calculation_code table.
… a temporary placement while the report is being developed)
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Failed Quality Gate failed for 'Pay Transparency Backend'

Failed conditions

20.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 2054ca0 into main Dec 21, 2023
12 of 13 checks passed
@sukanya-rath sukanya-rath deleted the feature/generate-report branch December 21, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants