Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/chart summary sentences #143

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Conversation

banders
Copy link
Contributor

@banders banders commented Jan 8, 2024

Description

Adds summary text below each bar chart in the report. The summary text describes (in words) the data depicted in the chart. The text is in a format similar to this:

"In this organization women's average hourly wages are 4% less than men's and non-binary people's average hourly wages are 1% less than men's. For every dollar men earn in average hourly wages, women earn 96 cents and non-binary people earn 99 cents in average hourly wages."

Fixes: Sub-requirements d. and h. from each of the following issues GEO-66, GEO-111, GEO-112, GEO-113.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

New unit tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Backend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
91.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 1bfe636 into main Jan 9, 2024
13 checks passed
@sukanya-rath sukanya-rath deleted the feature/chart-summary-sentences branch January 9, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants