Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/bootstrap download blocked #144

Merged
merged 12 commits into from
Jan 9, 2024
Merged

Conversation

banders
Copy link
Contributor

@banders banders commented Jan 9, 2024

Description

Removed the bootstrap CSS (CDN) dependency that was included in the HTML report. That dependency was problematic because it caused style conflicts between the report and the rest of the page the contains the report, and also because in some deployments the browser wasn't able to download the dependency at all.

Added a little bit of new CSS directly to the report to handle formatting of elements that we previously relied on bootstrap for. (This also fixes the unwanted cellpading in the "Employer details" table at the top of the report.)

Other minor content organization and wording updates to the report.

Also fixed an existing unit test that was failing in the doc-gen-service.

Fixes (GEO-183)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Existing unit tests. Visual test in a browser.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

@sukanya-rath sukanya-rath merged commit ba1363c into main Jan 9, 2024
12 checks passed
@sukanya-rath sukanya-rath deleted the bug/bootstrap-download-blocked branch January 9, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants