-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/bootstrap download blocked #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e all css styles needed for the report directly in the report template)
sukanya-rath
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the bootstrap CSS (CDN) dependency that was included in the HTML report. That dependency was problematic because it caused style conflicts between the report and the rest of the page the contains the report, and also because in some deployments the browser wasn't able to download the dependency at all.
Added a little bit of new CSS directly to the report to handle formatting of elements that we previously relied on bootstrap for. (This also fixes the unwanted cellpading in the "Employer details" table at the top of the report.)
Other minor content organization and wording updates to the report.
Also fixed an existing unit test that was failing in the doc-gen-service.
Fixes (GEO-183)
Type of change
How Has This Been Tested?
Existing unit tests. Visual test in a browser.
Checklist
Thanks for the PR!
Deployments, as required, will be available below: