Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Form Screen UI Page #47

Merged
merged 14 commits into from
Nov 7, 2023
Merged

Input Form Screen UI Page #47

merged 14 commits into from
Nov 7, 2023

Conversation

banders
Copy link
Contributor

@banders banders commented Nov 3, 2023

Description

  • Renamed the GenerateReport component to InputForm
  • Expanded the form to include all require input fields (new fields are: including NAICS code, start date, end date, comments)
  • Added constraints on the date fields to restrict the date range to a 12 month period in the last 2 years.

None of the input fields are connected to data from the backend yet. Those integrations can be made as a next step. The submit button is also non functional because the backend endpoint for this isn't ready yet.

Fixes # (issue)

https://finrms.atlassian.net/browse/GEO-77

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • New unit test to confirm that the page includes all the required form elements
  • New unit test to confirm that the end date is automatically set one year after the start date

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Copy link

sonarcloud bot commented Nov 6, 2023

[Pay Transparency Backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

sonarcloud bot commented Nov 6, 2023

[Pay Transparency Frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sukanya-rath sukanya-rath merged commit 9565bca into main Nov 7, 2023
10 of 12 checks passed
@sukanya-rath sukanya-rath deleted the feature/input-form branch November 7, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants