-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: env vars to configure user error logging #557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, and b) schedule delete of old errors
Quality Gate passed for 'Pay Transparency doc-gen-service'Issues Measures |
sukanya-rath
approved these changes
Jun 27, 2024
Quality Gate passed for 'Pay Transparency Backend'Issues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a scheduled job to periodically delete old records from the 'user_error' database table. Added two new env vars to control the scheduled delete (DELETE_USER_ERRORS_CRON_CRONTIME and NUM_MONTHS_OF_USER_ERRORS_TO_KEEP), and also added one new env var to enable/disable user error logging altogether (IS_USER_ERROR_LOGGING_ENABLED).
Note: for local testing add the following to backend .env file:
IS_USER_ERROR_LOGGING_ENABLED=FALSE
DELETE_USER_ERRORS_CRON_CRONTIME="30 0 1 * *"
NUM_MONTHS_OF_USER_ERRORS_TO_KEEP=6
Fixes # GEO-700 and GEO-899
Type of change
How Has This Been Tested?
New unit tests. Updated existing unit tests.
Checklist
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: