Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: env vars to configure user error logging #557

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented Jun 26, 2024

Description

Added a scheduled job to periodically delete old records from the 'user_error' database table. Added two new env vars to control the scheduled delete (DELETE_USER_ERRORS_CRON_CRONTIME and NUM_MONTHS_OF_USER_ERRORS_TO_KEEP), and also added one new env var to enable/disable user error logging altogether (IS_USER_ERROR_LOGGING_ENABLED).

Note: for local testing add the following to backend .env file:

IS_USER_ERROR_LOGGING_ENABLED=FALSE
DELETE_USER_ERRORS_CRON_CRONTIME="30 0 1 * *"
NUM_MONTHS_OF_USER_ERRORS_TO_KEEP=6

Fixes # GEO-700 and GEO-899

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

New unit tests. Updated existing unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 27, 2024

@sukanya-rath sukanya-rath merged commit 279ceae into main Jun 27, 2024
33 checks passed
@sukanya-rath sukanya-rath deleted the feat/backend-err-service branch June 27, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants