Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using jsonwebtoken to decode token payload instead of atob and json parse token #572

Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix: using jsonwebtoken to decode token payload instead of atob and json parse token #572

merged 2 commits into from
Jul 9, 2024

Conversation

goemen
Copy link
Contributor

@goemen goemen commented Jul 9, 2024 •
edited by github-actions bot
Loading

Description

Using jsonwebtoken to decode token payload instead of atob and json parse token

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@goemen goemen requested a review from sukanya-rath as a code owner July 9, 2024 22:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 9, 2024
View reviewed changes
backend/src/v1/services/utils-service.spec.ts Dismissed Show dismissed Hide dismissed
backend/src/v1/services/utils-service.spec.ts Dismissed Show dismissed Hide dismissed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency admin-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 360e965 into main Jul 9, 2024
33 checks passed
@sukanya-rath sukanya-rath deleted the fix/GEO-967-prod-login-error branch July 9, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukanya-rath sukanya-rath sukanya-rath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goemen @sukanya-rath