Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/validate submission #66

Merged
merged 65 commits into from
Nov 26, 2023
Merged

Feature/validate submission #66

merged 65 commits into from
Nov 26, 2023

Conversation

banders
Copy link
Contributor

@banders banders commented Nov 22, 2023 •
edited
Loading

Description

Two changes to CSV validation

  • Permit a maximum value of 8760 for columns in units of hours (8760 is the number of hours in one year)
  • Disallow the value "N/A" in all columns (instead expect 0 or an empty string)

Fixes # (issue)

These are tweaks related to https://finrms.atlassian.net/browse/GEO-70 based on revised requirements discussed at today's scrum and in subsequent email exchanges with the team.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Several unit tests have been updated to confirm proper validation behaviour for valid and invalid values for the affected CSV columns.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

@banders
added moment.js as dependency
2b07f72
@banders
migration to insert data into 'employee_count_range' table
805eba8
@banders
added a new route '/codes/employee_count_range'. created a new 'code-…
7e56513 
…service' to support the implementation of this route. added a test case for the new service.
@banders
replaced underscores with dashes in the route '/<v>/codes/employee-co…
9b74fca 
…unt-range' to be consistent with the '/file-upload' endpoint.
@banders
Merge branch 'main' into feature/get-api-employee-range-count
e24775a
@banders
removed debug statement
08aeb78
@banders
made employee_count_range.expiry_date an optional column with null as…
628ac14 
… the default value. removed the 'expiry_date' column from insert statements (so nulls are inserted)
@banders
updated column employee_count_range.expiry_date to be optional with n…
3f71673 
…o default
@banders
code cleanup to test for getAllEmployeeCountRanges()
125ea89
@banders
updated query in getAllEmployeeCountRanges() to include records with …
908580e 
…null expiry_date (if effective_date is valid)
@banders
Merge branch 'main' of https://github.com/bcgov/fin-pay-transparency
086e8b3
@banders
fixed merge conflicts
3c703ea
@banders
fixed merge conflicts
b144aa0
@banders
fixed merge conflicts
936dade
@banders
fixed merge conflicts
59bd5a5
@banders
Merge branch 'main' of https://github.com/bcgov/fin-pay-transparency
a3109a4
@banders
Merge branch 'main' into feature/populate-input-form
6c24c7e
@banders
added a new 'store' to manage retrieval and storage of static content…
ccd366d 
… (employee count ranges and naics codes) from the backend.
@banders
added new functions getEmployeeCountRanges() and getNaicsCodes() to c…
4c4c6fb 
…ommunicate with backend endpoints
@banders
added EMPLOYEE_COUNT_RANGES with path to backend endpoint
4c53418
@banders
made InputForm route require auth
30e8e57
@banders
fixed route from 'Generate Pay Transparency Report' button
214b53b
@banders
integrated employee count ranges and company info
3fa4227
@banders
updated the pinia/testing library to help with mocking stores in comp…
4f2a17d 
…onent tests. upgraded the pinia and vue versions (required to use pinia/testing)
@banders
updated the pinia/testing library to help with mocking stores in comp…
a6bf2d1 
…onent tests. upgraded the pinia and vue versions (required to use pinia/testing)
@banders
added 'ref' attributes to some form fields so Vuetify components can …
1d02d82 
…be accessed from unit tests. also removed an unneeded state varaible
@banders
injected a 'test pinia' into the mounted component to allow testing o…
45e9a87 
…f behaviour that depends on the 'code store'. added new unit tests for the 'employee count ranges' and 'naics code
@banders
bump vuetify version to 3.4.0
96fbcd2
@banders
add new function to post the file upload submission
50d0e65
@banders
added form validation.
34217b3
@banders
fixed the path of ApiService import
9356c16
@banders
preliminary unit test
9b8e647
@banders
Merge branch 'feature/populate-input-form' into feature/validate-subm…
e49bb55 
…ission
@banders
50mb limit on fie uploads
d68c5a9
@banders
Merge branch 'main' of https://github.com/bcgov/fin-pay-transparency
cd0c295
@banders
Merge branch 'main' into feature/validate-submission
085d190
@banders
added additional validation checks
d5c4f32
@banders
added new tests and updated existing tests for better clarity.
fe050ff
@banders
Merge branch 'main' of https://github.com/bcgov/fin-pay-transparency
46fe7b9
@banders
Merge branch 'main' into feature/validate-submission
ff9abed
@banders
slightly loosened validation checks on the required header columns to…
40e1114 
… avoid throwing errors when extra 'blank' columns are found in the CSV (because of extra commas at the ends of lines)
@banders
fixed a bug in which certain CSV validation errors weren't correctly …
4ecf747 
…displayed.
@banders
add more info to error message
be08b76
@banders
changed maximum value for all 'hours' columns to 8760 hours
0c345ec
@banders
Merge branch 'main' of https://github.com/bcgov/fin-pay-transparency
76606a0
@banders
resolved merge conflicts
b444882
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

[Pay Transparency Backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

[Pay Transparency Frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sukanya-rath sukanya-rath merged commit c47cc1d into main Nov 26, 2023
13 checks passed
@sukanya-rath sukanya-rath deleted the feature/validate-submission branch November 26, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukanya-rath sukanya-rath sukanya-rath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banders @sukanya-rath