Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dashboard and form formatting #67

Merged
merged 21 commits into from
Nov 26, 2023

Conversation

banders
Copy link
Contributor

@banders banders commented Nov 22, 2023

Description

  • Dashboard page: changed color of buttons and section headers to match the dark blue in the application header/footer.
  • InputForm page: fixed the height of the footer. It no longer looks compressed or cut off.

Fixes # https://finrms.atlassian.net/browse/GEO-115

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Visual inspection within the web app. No new unit tests for these minor cosmetic changes. Let me know if you think unit tests are necessary.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

…service' to support the implementation of this route. added a test case for the new service.
…unt-range' to be consistent with the '/file-upload' endpoint.
… the default value. removed the 'expiry_date' column from insert statements (so nulls are inserted)
…null expiry_date (if effective_date is valid)
…and it was causing rendering problems. other formatting by linter.
Copy link

sonarcloud bot commented Nov 26, 2023

[Pay Transparency Backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

sonarcloud bot commented Nov 26, 2023

[Pay Transparency Frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sukanya-rath sukanya-rath merged commit 8058212 into main Nov 26, 2023
13 checks passed
@sukanya-rath sukanya-rath deleted the feature/dashboard-and-form-formatting branch November 26, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants