Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GEO-1095 - admin announcement preview always visible #716

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented Sep 3, 2024

In the admin app:

  • Add/edit announcement now makes the "preview" panel always visible. No need to click a "preview" button to see it.
  • Replace the "Draft" and "Published" radio button labels with "chips" for visual consistency with the main Announcements page.

Fixes # GEO-1095, GEO-1102

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Updated existing unit tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@banders banders marked this pull request as draft September 3, 2024 23:05
@banders banders marked this pull request as ready for review September 3, 2024 23:13
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency admin-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jer3k jer3k merged commit ec1ac39 into main Sep 4, 2024
45 checks passed
@jer3k jer3k deleted the feat/admin-announcement-preview-always-visible branch September 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants