fix: Fetch announcement with the edit button is clicked #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in this commit add error handling for the case when the retrieval of an announcement fails. When the `editAnnouncement` function is called, it now makes an API request to retrieve the announcement using the `getAnnouncement` method from the `ApiService`. If the retrieval is successful, the announcement is set in the `announcementSelectionStore` and the user is redirected to the edit announcement page. However, if the retrieval fails, an error message is displayed using the `NotificationService`. This commit also includes recent user commits and recent repository commits for reference.
goemen
force-pushed
the
GEO-1085-the-save-as-draft-option-is-not-available-after-i-unpublish-a-published-announcement-and-go-into-edit-the-first-time
branch
from
7de79f8
to
940047f
Compare
|
|
|
|
|
jer3k
approved these changes
Sep 5, 2024
jer3k
deleted the
GEO-1085-the-save-as-draft-option-is-not-available-after-i-unpublish-a-published-announcement-and-go-into-edit-the-first-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code changes in this commit add error handling for the case when the retrieval of an announcement fails. When the
editAnnouncementfunction is called, it now makes an API request to retrieve the announcement using thegetAnnouncementmethod from theApiService. If the retrieval is successful, the announcement is set in theannouncementSelectionStoreand the user is redirected to the edit announcement page. However, if the retrieval fails, an error message is displayed using theNotificationService.Fixes # (issue)
Type of change
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: