Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GEO-1098 datetime cleanups #725

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: GEO-1098 datetime cleanups #725

merged 2 commits into from
Sep 5, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented Sep 5, 2024

Description

  • Fixed an timezone problem related to the expiry date of pending user invitations on the admin site.
  • Removed a backend function in report-service that's no longer needed (it contained a suspicious datetime usage, but rather than fix the usage, it made more sense to remove the function).

Fixes # GEO-1098

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Existing unit tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

@goemen goemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 5, 2024

Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency admin-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 5, 2024

@sukanya-rath sukanya-rath merged commit 6aaa2bd into main Sep 5, 2024
32 checks passed
@sukanya-rath sukanya-rath deleted the fix/datetime-cleanups branch September 5, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants