Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CSV validation rules #88

Merged
merged 1 commit into from
Dec 6, 2023
Merged

New CSV validation rules #88

merged 1 commit into from
Dec 6, 2023

Conversation

banders
Copy link
Contributor

@banders banders commented Dec 6, 2023

Description

Added two new CSV validation rules:

  • Hours Worked can not be blank or 0 if Ordinary Pay contains data.
  • Ordinary Pay can not be blank or 0 if Hours Worked contains data.

Fixes # (GEO-141)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • One new unit tests for each of the new validation rules

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

…rdinary Pay from containing data (either both or neither must contain data)
Copy link

sonarcloud bot commented Dec 6, 2023

[Pay Transparency Backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sukanya-rath sukanya-rath merged commit 2fbaf08 into main Dec 6, 2023
13 checks passed
@sukanya-rath sukanya-rath deleted the feature/validate-csv branch December 6, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants