Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ESLint GEO-95 #95

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Feature/ESLint GEO-95 #95

merged 6 commits into from
Dec 12, 2023

Conversation

jer3k
Copy link
Contributor

@jer3k jer3k commented Dec 11, 2023 •
edited by github-actions bot
Loading

  • Added ESLint and prettier in the backend and frontend.
  • Added recommended plugins for ESLint and Prettier in VSCode.
  • Added Launch configuration for VSCode.

Issues:

  • I couldn't get jest linting to work in the frontend, I tried everything I could think of.

Thanks for the PR!

Deployments, as required, will be available below:

@jer3k jer3k marked this pull request as ready for review December 11, 2023 21:29
sukanya-rath
sukanya-rath reviewed Dec 11, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[Pay Transparency Backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[Pay Transparency Frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sukanya-rath sukanya-rath merged commit c187346 into main Dec 12, 2023
14 checks passed
@sukanya-rath sukanya-rath deleted the feature/eslint-GEO-95 branch December 12, 2023 00:27
@jer3k jer3k restored the feature/eslint-GEO-95 branch December 12, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukanya-rath sukanya-rath sukanya-rath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jer3k @sukanya-rath