Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring wildlife and allegation api #177

Merged
merged 18 commits into from
Oct 27, 2023
Merged

Refactoring wildlife and allegation api #177

merged 18 commits into from
Oct 27, 2023

Conversation

marqueone-ps
Copy link
Contributor

@marqueone-ps marqueone-ps commented Oct 27, 2023 •
edited by github-actions bot
Loading

Description

Refactor hwcr_complaint and allegation_complaint api's to reduce controller complexity, and duplicated code in the services

Fixes # CE-190

How Has This Been Tested?

Existing unit tests have been updated to satisfy refactoring

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 05:28 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 05:28 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 05:28 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 05:28 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:24 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:24 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:24 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:24 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:41 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:41 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:41 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 17:41 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 18:46 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 18:46 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 18:46 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 18:49 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 18:49 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 18:49 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps marked this pull request as ready for review October 27, 2023 19:04
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:05 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:05 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:05 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:05 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:42 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:42 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:42 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 19:42 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 21:06 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 21:06 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 21:06 — with GitHub Actions Inactive
@marqueone-ps marqueone-ps temporarily deployed to dev October 27, 2023 21:06 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
42.2% 42.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@afwilcox afwilcox temporarily deployed to dev October 27, 2023 21:55 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 27, 2023 21:55 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 27, 2023 21:55 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 27, 2023 21:55 — with GitHub Actions Inactive
@afwilcox afwilcox added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit 7582537 Oct 27, 2023
14 of 16 checks passed
@afwilcox afwilcox deleted the refactor/CE-190 branch October 27, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afwilcox afwilcox afwilcox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marqueone-ps @afwilcox