feat: CE-882 versioning on prod releasesv2 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| id: bump_version | ||
| run: | | ||
| latest_tag="${{ steps.latest_tag.outputs.latest_tag }}" | ||
| # Extract major, minor, and patch versions |
There was a problem hiding this comment.
I don't think yml file supports comment inside a block scalar
Scarlett-Truong
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@barrfalk LGTM. I just wonder about "#" inside run block (there're 5 of them), it may not understand that it's a comment and run the command, but not a big deal.
We might consider updating version when merging hotfix branch to main as well.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A tag is created when a release branch is created.
Merging into a release branch will increment the patch number of a version.
Merging into main will create a github release.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: