Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: TFRS: Add Redis Service for organization balance #2919

Open
wants to merge 10 commits into
base: release-2.22.0
Choose a base branch
from

Conversation

prv-proton
Copy link
Collaborator

TFRS: Add Redis Service for Local Development
#1078

TFRS: Setup Redis Service and Call LCFS Cache for Available Balances
#1074

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a couple items to add. ty

@@ -0,0 +1,96 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some more documentation here to explain the purpose and use case for this shell script please.

"""Seed initial data into Redis cache"""
try:
# Check if data has already been seeded to avoid duplicates
if not redis_cache.get('redis_seeded'):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to ensure this flag is set on the LCFS side as well when it populates its live cache. Please just confirm that is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants