You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the Bug
It looks like certain reassessments/supplementary reports are being excluded from the report history.
Expected Behaviour
I expect to see an accurate timeline of reports.
Actual Behaviour
There is a case where the most recent reassessment does not appear in the timeline.
Implications
This may confuse some users.
Steps To Reproduce
At the time of this writing: on dev, as a government user, go to Ford's 2021 reports. By navigating to the topmost (most recent) entry in the timeline, one will see a report that is not, in fact, the most recent report (which is supposed to be an assessed reassessment with a balance of 1598.88 A credits, and 0 B credits). Note that upon first landing on the page, you will see the correct report; it is only by navigating to a different entry then navigating back will one see a report that one should not be seeing.
Notes
I think this is a a backend issue; see the supplemental_history endpoint in viewsets/model_year_report.py. There is some logic in there concerning which supplemental reports to exclude that should probably be reviewed. Also, in SupplementalReportSerializer in serializers/model_year_report_noa.py, there is some logic about how to display the status of a supplemental report that should also be reviewed.
The text was updated successfully, but these errors were encountered:
Describe the Bug
It looks like certain reassessments/supplementary reports are being excluded from the report history.
Expected Behaviour
I expect to see an accurate timeline of reports.
Actual Behaviour
There is a case where the most recent reassessment does not appear in the timeline.
Implications
This may confuse some users.
Steps To Reproduce
At the time of this writing: on dev, as a government user, go to Ford's 2021 reports. By navigating to the topmost (most recent) entry in the timeline, one will see a report that is not, in fact, the most recent report (which is supposed to be an assessed reassessment with a balance of 1598.88 A credits, and 0 B credits). Note that upon first landing on the page, you will see the correct report; it is only by navigating to a different entry then navigating back will one see a report that one should not be seeing.
Notes
I think this is a a backend issue; see the supplemental_history endpoint in viewsets/model_year_report.py. There is some logic in there concerning which supplemental reports to exclude that should probably be reviewed. Also, in SupplementalReportSerializer in serializers/model_year_report_noa.py, there is some logic about how to display the status of a supplemental report that should also be reviewed.
The text was updated successfully, but these errors were encountered: