Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEVA - report history #1868

Closed
tim738745 opened this issue Jul 25, 2023 · 1 comment
Closed

ZEVA - report history #1868

tim738745 opened this issue Jul 25, 2023 · 1 comment
Assignees
Labels
Bug Something isn't working Medium Medium Priority Tested :) Passed testing

Comments

@tim738745
Copy link
Collaborator

Describe the Bug
It looks like certain reassessments/supplementary reports are being excluded from the report history.

Expected Behaviour
I expect to see an accurate timeline of reports.

Actual Behaviour
There is a case where the most recent reassessment does not appear in the timeline.

Implications
This may confuse some users.

Steps To Reproduce
At the time of this writing: on dev, as a government user, go to Ford's 2021 reports. By navigating to the topmost (most recent) entry in the timeline, one will see a report that is not, in fact, the most recent report (which is supposed to be an assessed reassessment with a balance of 1598.88 A credits, and 0 B credits). Note that upon first landing on the page, you will see the correct report; it is only by navigating to a different entry then navigating back will one see a report that one should not be seeing.

Notes
I think this is a a backend issue; see the supplemental_history endpoint in viewsets/model_year_report.py. There is some logic in there concerning which supplemental reports to exclude that should probably be reviewed. Also, in SupplementalReportSerializer in serializers/model_year_report_noa.py, there is some logic about how to display the status of a supplemental report that should also be reviewed.

@tim738745 tim738745 added Bug Something isn't working Low Low priority labels Jul 25, 2023
@kcabhar
Copy link
Contributor

kcabhar commented Jul 26, 2023

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @JulianForeman @tim738745

@jdon-zev jdon-zev added Medium Medium Priority and removed Low Low priority labels Jul 26, 2023
@JulianForeman JulianForeman self-assigned this Aug 10, 2023
tim738745 pushed a commit that referenced this issue Aug 16, 2023
* Added logic to exclude supplemental report from the reporting timeline if a reassessment has started for it

* Improved logic
@airinggov airinggov added the Tested :) Passed testing label Aug 22, 2023
kuanfandevops added a commit that referenced this issue Aug 22, 2023
* update to 1.49.0

* update workflows (#1917)

* update release process (#1919)

* Fix - Reassessment/Supplementary Report Timeline #1868 (#1920)

* Added logic to exclude supplemental report from the reporting timeline if a reassessment has started for it

* Improved logic

* fix: zeva-1862 - cannot remove zero (#1923)

* feat: zeva-1755 -  move supplementary report and print buttons (#1921)

* fiz: zeva-1838 - supplementary report director save button (#1918)

* Update prod release approvals to 2

* Disable save button on click to prevent multiple save actions from firing (#1925)

* fix: zeva-1832 - negative zero fix (#1922)

* fix: zeva-1789 - credit-transfer-error (#1924)

* fix: zeva-1926 - reassessment-ldv-sales (#1927)

---------

Co-authored-by: Kuan Fan <[email protected]>
Co-authored-by: JulianForeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Medium Priority Tested :) Passed testing
Projects
None yet
Development

No branches or pull requests

5 participants