Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEVA: frontend validation of uploaded spreadsheet #2220

Closed
tim738745 opened this issue Aug 20, 2024 · 2 comments
Closed

ZEVA: frontend validation of uploaded spreadsheet #2220

tim738745 opened this issue Aug 20, 2024 · 2 comments
Assignees
@JulianForeman
Labels
High High priority ticket but not critical at this time Task Any work that does not directly impact the user Tested :) Passed testing

Comments

@tim738745
Copy link
Collaborator

Please implement the validateRecords() function in src/salesforecast/components/RecordsUpload.js. Additional notes are available as comments in the body of the aforementioned function.
@shayjeff shayjeff added Task Any work that does not directly impact the user High High priority ticket but not critical at this time labels Aug 20, 2024
@JulianForeman JulianForeman self-assigned this Aug 21, 2024
tim738745 pushed a commit that referenced this issue Aug 26, 2024
@JulianForeman
Task: Frontend Spreadsheet Record Validation #2220 (#2228)
18bb3ff 
* Frontend validation for SalesForecastRecord records.

* Fixing casing

* Cleanup
tim738745 pushed a commit that referenced this issue Sep 10, 2024
@JulianForeman @tim738745
Task: Frontend Spreadsheet Record Validation #2220 (#2228)
5c2039b 
* Frontend validation for SalesForecastRecord records.

* Fixing casing

* Cleanup
@katerinkus
Copy link
Collaborator

katerinkus commented Sep 24, 2024 •
edited
Loading

@tim738745 @JulianForeman

  • Model year - 4 integers. A nice to have would be limit (i.e. some realistic time range). Right now I can add 1700 and it is fine.
  • Make - 250 chars.
  • Model - 250 chars.
  • Type
  • Range - 2 decimals.
  • ZEV Class - Allowed me to put in a letter that was not A, B or C.
  • Vehicle Class and Interior Volume - Allowed me to put in random category ("Some car").
  • ZEV supply forecast - must be a number.

@katerinkus katerinkus added the Tested w/ issues Testing did not pass label Sep 24, 2024
tim738745 pushed a commit that referenced this issue Sep 25, 2024
@JulianForeman @tim738745
Task: Frontend Spreadsheet Record Validation #2220 (#2228)
d7f5ae4 
* Frontend validation for SalesForecastRecord records.

* Fixing casing

* Cleanup
@katerinkus
Copy link
Collaborator

Resolved here: #2272

@katerinkus katerinkus added Tested :) Passed testing and removed Tested w/ issues Testing did not pass labels Sep 26, 2024
tim738745 added a commit that referenced this issue Sep 27, 2024
@tim738745 @JulianForeman
Oct 1 2024 stuff -- build-on-dev (#2226)
80512e9 
* feat: 2207 - sales forecast (#2211)

* initial commit

* small change

* sales forecast backend

* feat: 2204 and 2209 - sales forecast (#2218)

* feat: 2204 and 2209 = sales forecast

* some changes

* wording changes

* some changes

* oct 1 stuff - spreadsheet column name changes (#2225)

* address codeQL-raised issue

* Task: Frontend Spreadsheet Record Validation #2220 (#2228)

* Frontend validation for SalesForecastRecord records.

* Fixing casing

* Cleanup

* feat: 2219 - forecast report column mapping + automatic summation of ZEVs supplied (#2231)

* feat: 2219 - forecast report colum mapping + automatic summation of ZEVs supplied

* small change

* fix totals display upon discard of records

* feat: 2221 - some styling (#2236)

* Task: Sales Forecast Report Checkbox Assertion #2222 (#2232)

* Adding new signing authority assertion for Sales Forecast

* Cleaning up

* wording changes

* formatting

* fix: amend download() function to take into account case where content-disposition is not an exposed header

* update template

* spreadsheet validation updates

* spreadsheet validation cleanup

* Added message for a successful or unsuccessful upload (#2278)

Co-authored-by: julianforeman <[email protected]>

* cleanup

---------

Co-authored-by: JulianForeman <[email protected]>
Co-authored-by: julianforeman <[email protected]>
kuanfandevops added a commit that referenced this issue Oct 1, 2024
@kuanfandevops @emi-hi
@tim738745 @JulianForeman
Tracking pull request to merge release-1.61.0 to master (#2270)
73c61fa 
* initial update for 1.61.0

* udpate pr number

* fix - adds is_government to basic user serializer (#2276)

* Oct 1 2024 stuff  -- build-on-dev (#2226)

* feat: 2207 - sales forecast (#2211)

* initial commit

* small change

* sales forecast backend

* feat: 2204 and 2209 - sales forecast (#2218)

* feat: 2204 and 2209 = sales forecast

* some changes

* wording changes

* some changes

* oct 1 stuff - spreadsheet column name changes (#2225)

* address codeQL-raised issue

* Task: Frontend Spreadsheet Record Validation #2220 (#2228)

* Frontend validation for SalesForecastRecord records.

* Fixing casing

* Cleanup

* feat: 2219 - forecast report column mapping + automatic summation of ZEVs supplied (#2231)

* feat: 2219 - forecast report colum mapping + automatic summation of ZEVs supplied

* small change

* fix totals display upon discard of records

* feat: 2221 - some styling (#2236)

* Task: Sales Forecast Report Checkbox Assertion #2222 (#2232)

* Adding new signing authority assertion for Sales Forecast

* Cleaning up

* wording changes

* formatting

* fix: amend download() function to take into account case where content-disposition is not an exposed header

* update template

* spreadsheet validation updates

* spreadsheet validation cleanup

* Added message for a successful or unsuccessful upload (#2278)

Co-authored-by: julianforeman <[email protected]>

* cleanup

---------

Co-authored-by: JulianForeman <[email protected]>
Co-authored-by: julianforeman <[email protected]>

* fix: comment edit (#2277)

* fix: adds context to update comment

* chore: removes extra spaces

---------

Co-authored-by: Emily <[email protected]>
Co-authored-by: tim738745 <[email protected]>
Co-authored-by: JulianForeman <[email protected]>
Co-authored-by: julianforeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianForeman JulianForeman

Labels
High High priority ticket but not critical at this time Task Any work that does not directly impact the user Tested :) Passed testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@katerinkus @JulianForeman @tim738745 @shayjeff