Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/2267 - remove commentator's name #2320

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

emi-hi
Copy link
Collaborator

@emi-hi emi-hi commented Oct 21, 2024

creates user mixin for displaying update or create users as a specific way depending on whether they are government or not and whether the request user is government or not

refactors code to use this mixin for both commenters and other update/create users

@emi-hi emi-hi requested a review from tim738745 October 21, 2024 17:40
@emi-hi emi-hi linked an issue Oct 21, 2024 that may be closed by this pull request
7 tasks
backend/api/viewsets/credit_agreement.py Outdated Show resolved Hide resolved
backend/api/mixins/user_mixin.py Outdated Show resolved Hide resolved
@emi-hi emi-hi requested a review from tim738745 October 25, 2024 23:57
@emi-hi emi-hi changed the base branch from release-1.63.0 to release-1.64.0 October 25, 2024 23:58
@emi-hi emi-hi changed the base branch from release-1.64.0 to release-1.63.0 October 26, 2024 00:03
@emi-hi emi-hi changed the base branch from release-1.63.0 to release-1.64.0 October 26, 2024 00:26
@emi-hi emi-hi marked this pull request as draft October 26, 2024 00:27
@emi-hi emi-hi marked this pull request as ready for review October 30, 2024 00:29
Copy link

sonarcloud bot commented Oct 31, 2024

@tim738745 tim738745 merged commit c822c0f into bcgov:release-1.64.0 Oct 31, 2024
5 checks passed
emi-hi added a commit to emi-hi/zeva that referenced this pull request Nov 7, 2024
* chore: removes get_serializer_context

* -refactors mixin and updates the files that use it
-adds extra check to credit transfers details page

* -fixes rebase issues

* chore:  removes commented code

* chore: adds mixin to sales submission list serializer so it passes test

* some fixes and changes

* some refactoring

---------

Co-authored-by: tim738745 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZEVA - remove commentator's name
2 participants