-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/2267 - remove commentator's name #2320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
tim738745
requested changes
Oct 22, 2024
-adds extra check to credit transfers details page
tim738745
approved these changes
Oct 30, 2024
Quality Gate passedIssues Measures |
emi-hi
added a commit
to emi-hi/zeva
that referenced
this pull request
Nov 7, 2024
* chore: removes get_serializer_context * -refactors mixin and updates the files that use it -adds extra check to credit transfers details page * -fixes rebase issues * chore: removes commented code * chore: adds mixin to sales submission list serializer so it passes test * some fixes and changes * some refactoring --------- Co-authored-by: tim738745 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates user mixin for displaying update or create users as a specific way depending on whether they are government or not and whether the request user is government or not
refactors code to use this mixin for both commenters and other update/create users