Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with the alerts changes I made #360

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Fixed an issue with the alerts changes I made #360

merged 2 commits into from
Oct 19, 2020

Conversation

amichard
Copy link
Contributor

Changelog:

  • I forgot to check for validationStatus in the front-end
  • Committed the migration that it was asking me to make
  • minor css changes

@amichard amichard requested a review from emi-hi October 19, 2020 18:44
@amichard amichard self-assigned this Oct 19, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emi-hi emi-hi merged commit d55a005 into bcgov:release-1.12.0 Oct 19, 2020
@amichard amichard deleted the migrations-and-alerts-fixes branch December 10, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emi-hi emi-hi emi-hi approved these changes

Assignees

@amichard amichard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amichard @emi-hi