Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEVA-563: Add function for retrieving obligation balances broken down by year #693

Merged
merged 2 commits into from
May 17, 2021
Merged

ZEVA-563: Add function for retrieving obligation balances broken down by year #693

merged 2 commits into from
May 17, 2021

Conversation

NavpreetGrewal
Copy link

  • Created a function to calculate prior year balance

** pending: current year balances calculation needs more discussion.

emi-hi
emi-hi reviewed May 17, 2021
View reviewed changes
Copy link
Collaborator

@emi-hi emi-hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prior year balance should be using the previous years ending balance

@sonarcloud
Copy link

sonarcloud bot commented May 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amichard amichard merged commit 010f2a1 into bcgov:release-1.26.0 May 17, 2021
@NavpreetGrewal NavpreetGrewal deleted the ZEVA-563 branch June 22, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emi-hi emi-hi emi-hi approved these changes

@amichard amichard Awaiting requested review from amichard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NavpreetGrewal @emi-hi @amichard