Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEVA-575:BCeID MY Report Update - Consumer (ZEV) Sales Page #700

Merged
merged 1 commit into from
May 20, 2021
Merged

ZEVA-575:BCeID MY Report Update - Consumer (ZEV) Sales Page #700

merged 1 commit into from
May 20, 2021

Conversation

NavpreetGrewal
Copy link

  • Removed code related to ldv_sales and previous_sales from consumer sales pages(frontend and backend)
  • Made some logic changes and moved code to the backend, (if confirmed, load data from snapshot else from DB)
  • created a fixture to update consumer_sales assertion text

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amichard amichard merged commit 02957f1 into bcgov:release-1.26.0 May 20, 2021
@NavpreetGrewal NavpreetGrewal deleted the ZEVA-575 branch June 22, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emi-hi emi-hi emi-hi approved these changes

@amichard amichard Awaiting requested review from amichard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NavpreetGrewal @emi-hi @amichard