Tracking pull request to merge release-1.27.0 to master #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to 1.26.0 * ZEVA-570:Change the logic for the effective dates for the the model year report (#687) * Add cronjob to restart Jenkins once a day (#692) * ZEVA 566: Class A Deficit and Unspecified Deficits (#689) * update to 1.25.0 * ZEVA 530 Obligation Frontend changes (#665) * update to 1.24.0 * ZEVA-466: Upgraded packages as recommended by the bot (#643) * update to 1.23.0 * Workflow changes for the analyst recommendation (#626) * ZEVA-475: Create database tables to support back-end for compliance obligation (#629) * Zeva 500 - Compliance Obligation Ratio reduction (#627) * update to 1.22.0 * ZEVA 511 - transfer signoff (#607) * update to 1.21.0 * Apply knp (#587) * update knps (#589) * ZEVA-473,474,480: Frontend Changes (#584) * update to 1.20.0 * ZEVA-457: Model Year Report - Index Page (front end) (#559) * ZEVA 444 - Ids CA and CT to alerts and tables (#558) * update to 1.19.0 * ZEVA-409: Email notifcation - unsubscribe (#535) * ZEVA-315: Clear Filter Button (#532) * Update to 1.18.0 * Compliance tabs (#511) * Update to release 1.17.0 * changed comments to be associated with history instead of transfer id (#465) * ZEVA 358 - Director reject comment (#461) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved * parameterize credit_transfers.enabled (#454) * update redirect ref name * switched transfer comment to use history table instead of transfer id * changed serializers so comment is associated with history instead of transfer id * Fixed an issue with credit calculation (#456) * added comment for director * added transfer comments for director to create, changed comment display on frontend so if there are comments they show up regardless of user, but backend only passes history and comments that the user is eligible to see * fixed conflicts * removed duplicate get validation status functions Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Kuan Fan <[email protected]> * ZEVA-365: Added Permission Checks for Credit Transfer and Credit Application (#458) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Added permission checks to signing credit transfer * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved * Added permission check for credit transfer * Removing duplicate get_submission_history * Added permission check to Credit Application * Removed useReducer Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> Co-authored-by: Kuan Fan <[email protected]> * Fixed the ordering in credit transaction page. Add association of credit transfer to credit transaction when recording credit transfers (#464) * Fixed permission errors (#466) * Fixed permission errors * Removed test code * Added typeof check to function (#467) * added new status for transfers - rescind_pre_approval, for when transfers are rescinded before making it to IDIR users, added that status to serializers so that when a transfer is rescinded it gets the correct rescind status, and the history now contains records of that status along with associated comments, added comments to front end form so initating users see comments when looking at rescinded transfer form (#468) * Update jenkins executor number to be 5 (#469) * update jenkins executor number to be 5 * update options.git.owner to bcgov under .pipeline * update options.git.owner to bcgov under .jenkins/.pipeline * Update User Fixtures (#473) * Added navpreet to fixture and emails for the users * Added email and keycloak email as part of the user creation * Added molly to fixtures * ZEVA 347 - Credit transfer status alerts (#470) * refactored alerts so tha each feature has its own file with logic to render alert component * updated files that previously used alert component to now use the individual alert for that feature * refactored comment so that comment array is more shallow before going to comment component, for all files using comment, so that they are standardized and more simple * added alert for transfers for edit form and details page * added more alert statuses, changed backend error message and added to alert file, added extra alert to appear if there is an insufficent balance * removed console log * added serializer method field to pass number of pending transfers to government user, removed error from transfer alerts and added to details page instead * added recorded transfer alert * fixed bugs, changed some wording in transfer list table (added name of rescind supplier, removed pre approval from rescind, added who rejected transfer), removed error alert from draft alert and moved directly into transfer form file * moved alert stories into their own files * fixed some tests to pass, still needs work * uncommented vehicle form alert and updated props * moved comments to below alerts * updated email address on dashboard from CEVinquiries to ZEVRegulations (#472) * ZEVA 360 - Delete transfer (#474) * refactored alerts so tha each feature has its own file with logic to render alert component * updated files that previously used alert component to now use the individual alert for that feature * refactored comment so that comment array is more shallow before going to comment component, for all files using comment, so that they are standardized and more simple * added alert for transfers for edit form and details page * added more alert statuses, changed backend error message and added to alert file, added extra alert to appear if there is an insufficent balance * removed console log * added serializer method field to pass number of pending transfers to government user, removed error from transfer alerts and added to details page instead * added recorded transfer alert * fixed bugs, changed some wording in transfer list table (added name of rescind supplier, removed pre approval from rescind, added who rejected transfer), removed error alert from draft alert and moved directly into transfer form file * moved alert stories into their own files * fixed some tests to pass, still needs work * uncommented vehicle form alert and updated props * moved comments to below alerts * adds delete button and modal for deleting draft transfers, excludes deleted transfers from list viewset * ZEVA-330, 331: Add email notification configurations for IDIR and BCeId user. (#471) * ZEVA-330: Add email notification configurations for IDIR user. * ZEVA-331: Add Notification Configuration for BCeID Users * Add basic unit test for Notification list rendering * Looks like duplicate code, maybe got merged with resolve conflicts. Removing it. Need to change this logic completly but this will be part of new PR. * Bump axios from 0.19.2 to 0.21.1 in /.pipeline (#475) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.19.2 to 0.21.1 in /.pipeline-v3 (#476) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update patroni health check and liveness check (#480) * ZEVA-369: Fixed Name Associated with the Status History (#478) * Added confirm dialog to reset the validated list * Fixed the government user name being used as part of the alert * Minor label changes/fixes (#483) * ZEVA-376, 379: Send email notification to Analyst and Director based on their subscription for credit transfer. (#482) * adds user prop to supplier tabs and checks permissions before showing tabs (#479) * Only deploy needed apps for test and prod (#486) * only deploy needed apps for test and prod * reduce patroni pod replica for dev * enable rabbitmq-secret-configmap-only.yaml * ZEVA-381: Send notifications to the transfer partner based on thier subscription for credit transfer (#485) * removed navbar link and activity section from bceid users that dont have permissions for sales and transfers (#487) * Automatically clear the error messsage when a new file is selected or when the current file is removed for Credit Applicationss (#484) * Remove openshift v3 and add upload process pod for testing (#488) * remove openshift v3 * add separate upload pod * added condition for displaying credit transaction tab in navbar to idir users (#489) * fixed condition for showing button on transfer modal (#490) * Fix Notification Alerts (#491) * ZEVA-381: Send notifications to the transfer partner based on thier subscription for credit transfer * Fix Notification alerts * Thursday Jan 8 Transfer bugs and changes (#494) * fixed condition for showing button on transfer modal * added disapproved to list of transfers idir users wont see * disabled submit button if there is an unfilled row on transfer form * fixed decimals on table * fixed decimals on total value of transfer for idir * fixed locationstate proptype, added link to transfer details from transaction list table, limited decimals on credit quantity to 0 and credit value to 2 for transfer handlerowinputchange, checked for empty array before displaying error alert for director * Added a command to populate the notification subscription for exiting users. Automatically select all notification subscriptions for new users (#492) * Fixed dashboard not showing the right banner for Approved (#493) * fixed rounding on transfer details table (#495) * Add dashboard red alert for "rejected by transfer partner" option. (#496) * Show Sign off checkboxes only if user has permission to submit the transfer (#497) * ZEVA-406: Dashboard now limits the finalized activities from 28 days to current date (#498) * Dashboard now limits the finalized activities from 28 days to current date * Changed sorting so that the one with changes are in the top * Notification fix (#499) * Restored validate_transfer call (#500) * ZEVA 394 - Vehicle workflow (#502) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * Notification in the front-end is now configurable (#501) * ZEVA 394: Vehicle workflow redirect (#503) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * fixed redirect for saving draft and submitting draft (now both direct to details page) * added else condition for redirecting vehicle details submit * set up compliance front end * zeva 394: Vehicle workflow fix (#504) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * fixed redirect for saving draft and submitting draft (now both direct to details page) * added else condition for redirecting vehicle details submit * set loading to false after vehicle status change * ZEVA-396: Fixed Filter for ICBC Verification Page (#505) * Fixed some of the filters * Fixed filtering for the vin list * Removed commented out code * Removed unused code * Fixed the reload by pushing a route to list then replacing it (#507) * added compliance to navbar, added compliance tabs and containers for the 3 main pages (sales, reports ratios) and details pages for each Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add send notification functionality for credit application. (#512) * ZEVA-372, 410: Fixed filtering for recorded transfers (#506) * Update to release 1.17.0 * changed comments to be associated with history instead of transfer id (#465) * ZEVA 358 - Director reject comment (#461) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved * parameterize c…
* Update to 1.26.0 * ZEVA-570:Change the logic for the effective dates for the the model year report (#687) * Add cronjob to restart Jenkins once a day (#692) * ZEVA 566: Class A Deficit and Unspecified Deficits (#689) * update to 1.25.0 * ZEVA 530 Obligation Frontend changes (#665) * update to 1.24.0 * ZEVA-466: Upgraded packages as recommended by the bot (#643) * update to 1.23.0 * Workflow changes for the analyst recommendation (#626) * ZEVA-475: Create database tables to support back-end for compliance obligation (#629) * Zeva 500 - Compliance Obligation Ratio reduction (#627) * update to 1.22.0 * ZEVA 511 - transfer signoff (#607) * update to 1.21.0 * Apply knp (#587) * update knps (#589) * ZEVA-473,474,480: Frontend Changes (#584) * update to 1.20.0 * ZEVA-457: Model Year Report - Index Page (front end) (#559) * ZEVA 444 - Ids CA and CT to alerts and tables (#558) * update to 1.19.0 * ZEVA-409: Email notifcation - unsubscribe (#535) * ZEVA-315: Clear Filter Button (#532) * Update to 1.18.0 * Compliance tabs (#511) * Update to release 1.17.0 * changed comments to be associated with history instead of transfer id (#465) * ZEVA 358 - Director reject comment (#461) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved * parameterize credit_transfers.enabled (#454) * update redirect ref name * switched transfer comment to use history table instead of transfer id * changed serializers so comment is associated with history instead of transfer id * Fixed an issue with credit calculation (#456) * added comment for director * added transfer comments for director to create, changed comment display on frontend so if there are comments they show up regardless of user, but backend only passes history and comments that the user is eligible to see * fixed conflicts * removed duplicate get validation status functions Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Kuan Fan <[email protected]> * ZEVA-365: Added Permission Checks for Credit Transfer and Credit Application (#458) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Added permission checks to signing credit transfer * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved * Added permission check for credit transfer * Removing duplicate get_submission_history * Added permission check to Credit Application * Removed useReducer Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> Co-authored-by: Kuan Fan <[email protected]> * Fixed the ordering in credit transaction page. Add association of credit transfer to credit transaction when recording credit transfers (#464) * Fixed permission errors (#466) * Fixed permission errors * Removed test code * Added typeof check to function (#467) * added new status for transfers - rescind_pre_approval, for when transfers are rescinded before making it to IDIR users, added that status to serializers so that when a transfer is rescinded it gets the correct rescind status, and the history now contains records of that status along with associated comments, added comments to front end form so initating users see comments when looking at rescinded transfer form (#468) * Update jenkins executor number to be 5 (#469) * update jenkins executor number to be 5 * update options.git.owner to bcgov under .pipeline * update options.git.owner to bcgov under .jenkins/.pipeline * Update User Fixtures (#473) * Added navpreet to fixture and emails for the users * Added email and keycloak email as part of the user creation * Added molly to fixtures * ZEVA 347 - Credit transfer status alerts (#470) * refactored alerts so tha each feature has its own file with logic to render alert component * updated files that previously used alert component to now use the individual alert for that feature * refactored comment so that comment array is more shallow before going to comment component, for all files using comment, so that they are standardized and more simple * added alert for transfers for edit form and details page * added more alert statuses, changed backend error message and added to alert file, added extra alert to appear if there is an insufficent balance * removed console log * added serializer method field to pass number of pending transfers to government user, removed error from transfer alerts and added to details page instead * added recorded transfer alert * fixed bugs, changed some wording in transfer list table (added name of rescind supplier, removed pre approval from rescind, added who rejected transfer), removed error alert from draft alert and moved directly into transfer form file * moved alert stories into their own files * fixed some tests to pass, still needs work * uncommented vehicle form alert and updated props * moved comments to below alerts * updated email address on dashboard from CEVinquiries to ZEVRegulations (#472) * ZEVA 360 - Delete transfer (#474) * refactored alerts so tha each feature has its own file with logic to render alert component * updated files that previously used alert component to now use the individual alert for that feature * refactored comment so that comment array is more shallow before going to comment component, for all files using comment, so that they are standardized and more simple * added alert for transfers for edit form and details page * added more alert statuses, changed backend error message and added to alert file, added extra alert to appear if there is an insufficent balance * removed console log * added serializer method field to pass number of pending transfers to government user, removed error from transfer alerts and added to details page instead * added recorded transfer alert * fixed bugs, changed some wording in transfer list table (added name of rescind supplier, removed pre approval from rescind, added who rejected transfer), removed error alert from draft alert and moved directly into transfer form file * moved alert stories into their own files * fixed some tests to pass, still needs work * uncommented vehicle form alert and updated props * moved comments to below alerts * adds delete button and modal for deleting draft transfers, excludes deleted transfers from list viewset * ZEVA-330, 331: Add email notification configurations for IDIR and BCeId user. (#471) * ZEVA-330: Add email notification configurations for IDIR user. * ZEVA-331: Add Notification Configuration for BCeID Users * Add basic unit test for Notification list rendering * Looks like duplicate code, maybe got merged with resolve conflicts. Removing it. Need to change this logic completly but this will be part of new PR. * Bump axios from 0.19.2 to 0.21.1 in /.pipeline (#475) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.19.2 to 0.21.1 in /.pipeline-v3 (#476) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update patroni health check and liveness check (#480) * ZEVA-369: Fixed Name Associated with the Status History (#478) * Added confirm dialog to reset the validated list * Fixed the government user name being used as part of the alert * Minor label changes/fixes (#483) * ZEVA-376, 379: Send email notification to Analyst and Director based on their subscription for credit transfer. (#482) * adds user prop to supplier tabs and checks permissions before showing tabs (#479) * Only deploy needed apps for test and prod (#486) * only deploy needed apps for test and prod * reduce patroni pod replica for dev * enable rabbitmq-secret-configmap-only.yaml * ZEVA-381: Send notifications to the transfer partner based on thier subscription for credit transfer (#485) * removed navbar link and activity section from bceid users that dont have permissions for sales and transfers (#487) * Automatically clear the error messsage when a new file is selected or when the current file is removed for Credit Applicationss (#484) * Remove openshift v3 and add upload process pod for testing (#488) * remove openshift v3 * add separate upload pod * added condition for displaying credit transaction tab in navbar to idir users (#489) * fixed condition for showing button on transfer modal (#490) * Fix Notification Alerts (#491) * ZEVA-381: Send notifications to the transfer partner based on thier subscription for credit transfer * Fix Notification alerts * Thursday Jan 8 Transfer bugs and changes (#494) * fixed condition for showing button on transfer modal * added disapproved to list of transfers idir users wont see * disabled submit button if there is an unfilled row on transfer form * fixed decimals on table * fixed decimals on total value of transfer for idir * fixed locationstate proptype, added link to transfer details from transaction list table, limited decimals on credit quantity to 0 and credit value to 2 for transfer handlerowinputchange, checked for empty array before displaying error alert for director * Added a command to populate the notification subscription for exiting users. Automatically select all notification subscriptions for new users (#492) * Fixed dashboard not showing the right banner for Approved (#493) * fixed rounding on transfer details table (#495) * Add dashboard red alert for "rejected by transfer partner" option. (#496) * Show Sign off checkboxes only if user has permission to submit the transfer (#497) * ZEVA-406: Dashboard now limits the finalized activities from 28 days to current date (#498) * Dashboard now limits the finalized activities from 28 days to current date * Changed sorting so that the one with changes are in the top * Notification fix (#499) * Restored validate_transfer call (#500) * ZEVA 394 - Vehicle workflow (#502) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * Notification in the front-end is now configurable (#501) * ZEVA 394: Vehicle workflow redirect (#503) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * fixed redirect for saving draft and submitting draft (now both direct to details page) * added else condition for redirecting vehicle details submit * set up compliance front end * zeva 394: Vehicle workflow fix (#504) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * fixed redirect for saving draft and submitting draft (now both direct to details page) * added else condition for redirecting vehicle details submit * set loading to false after vehicle status change * ZEVA-396: Fixed Filter for ICBC Verification Page (#505) * Fixed some of the filters * Fixed filtering for the vin list * Removed commented out code * Removed unused code * Fixed the reload by pushing a route to list then replacing it (#507) * added compliance to navbar, added compliance tabs and containers for the 3 main pages (sales, reports ratios) and details pages for each Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add send notification functionality for credit application. (#512) * ZEVA-372, 410: Fixed filtering for recorded transfers (#506) * Update to release 1.17.0 * changed comments to be associated with history instead of transfer id (#465) * ZEVA 358 - Director reject comment (#461) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission an…
* ZEVA-596: Delete function - for previous model year sales figures * Add None to id if is no delete call * Rename variable
* Update to 1.26.0 * ZEVA-570:Change the logic for the effective dates for the the model year report (#687) * Add cronjob to restart Jenkins once a day (#692) * ZEVA 566: Class A Deficit and Unspecified Deficits (#689) * update to 1.25.0 * ZEVA 530 Obligation Frontend changes (#665) * update to 1.24.0 * ZEVA-466: Upgraded packages as recommended by the bot (#643) * update to 1.23.0 * Workflow changes for the analyst recommendation (#626) * ZEVA-475: Create database tables to support back-end for compliance obligation (#629) * Zeva 500 - Compliance Obligation Ratio reduction (#627) * update to 1.22.0 * ZEVA 511 - transfer signoff (#607) * update to 1.21.0 * Apply knp (#587) * update knps (#589) * ZEVA-473,474,480: Frontend Changes (#584) * update to 1.20.0 * ZEVA-457: Model Year Report - Index Page (front end) (#559) * ZEVA 444 - Ids CA and CT to alerts and tables (#558) * update to 1.19.0 * ZEVA-409: Email notifcation - unsubscribe (#535) * ZEVA-315: Clear Filter Button (#532) * Update to 1.18.0 * Compliance tabs (#511) * Update to release 1.17.0 * changed comments to be associated with history instead of transfer id (#465) * ZEVA 358 - Director reject comment (#461) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved * parameterize credit_transfers.enabled (#454) * update redirect ref name * switched transfer comment to use history table instead of transfer id * changed serializers so comment is associated with history instead of transfer id * Fixed an issue with credit calculation (#456) * added comment for director * added transfer comments for director to create, changed comment display on frontend so if there are comments they show up regardless of user, but backend only passes history and comments that the user is eligible to see * fixed conflicts * removed duplicate get validation status functions Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Kuan Fan <[email protected]> * ZEVA-365: Added Permission Checks for Credit Transfer and Credit Application (#458) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Added permission checks to signing credit transfer * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved * Added permission check for credit transfer * Removing duplicate get_submission_history * Added permission check to Credit Application * Removed useReducer Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> Co-authored-by: Kuan Fan <[email protected]> * Fixed the ordering in credit transaction page. Add association of credit transfer to credit transaction when recording credit transfers (#464) * Fixed permission errors (#466) * Fixed permission errors * Removed test code * Added typeof check to function (#467) * added new status for transfers - rescind_pre_approval, for when transfers are rescinded before making it to IDIR users, added that status to serializers so that when a transfer is rescinded it gets the correct rescind status, and the history now contains records of that status along with associated comments, added comments to front end form so initating users see comments when looking at rescinded transfer form (#468) * Update jenkins executor number to be 5 (#469) * update jenkins executor number to be 5 * update options.git.owner to bcgov under .pipeline * update options.git.owner to bcgov under .jenkins/.pipeline * Update User Fixtures (#473) * Added navpreet to fixture and emails for the users * Added email and keycloak email as part of the user creation * Added molly to fixtures * ZEVA 347 - Credit transfer status alerts (#470) * refactored alerts so tha each feature has its own file with logic to render alert component * updated files that previously used alert component to now use the individual alert for that feature * refactored comment so that comment array is more shallow before going to comment component, for all files using comment, so that they are standardized and more simple * added alert for transfers for edit form and details page * added more alert statuses, changed backend error message and added to alert file, added extra alert to appear if there is an insufficent balance * removed console log * added serializer method field to pass number of pending transfers to government user, removed error from transfer alerts and added to details page instead * added recorded transfer alert * fixed bugs, changed some wording in transfer list table (added name of rescind supplier, removed pre approval from rescind, added who rejected transfer), removed error alert from draft alert and moved directly into transfer form file * moved alert stories into their own files * fixed some tests to pass, still needs work * uncommented vehicle form alert and updated props * moved comments to below alerts * updated email address on dashboard from CEVinquiries to ZEVRegulations (#472) * ZEVA 360 - Delete transfer (#474) * refactored alerts so tha each feature has its own file with logic to render alert component * updated files that previously used alert component to now use the individual alert for that feature * refactored comment so that comment array is more shallow before going to comment component, for all files using comment, so that they are standardized and more simple * added alert for transfers for edit form and details page * added more alert statuses, changed backend error message and added to alert file, added extra alert to appear if there is an insufficent balance * removed console log * added serializer method field to pass number of pending transfers to government user, removed error from transfer alerts and added to details page instead * added recorded transfer alert * fixed bugs, changed some wording in transfer list table (added name of rescind supplier, removed pre approval from rescind, added who rejected transfer), removed error alert from draft alert and moved directly into transfer form file * moved alert stories into their own files * fixed some tests to pass, still needs work * uncommented vehicle form alert and updated props * moved comments to below alerts * adds delete button and modal for deleting draft transfers, excludes deleted transfers from list viewset * ZEVA-330, 331: Add email notification configurations for IDIR and BCeId user. (#471) * ZEVA-330: Add email notification configurations for IDIR user. * ZEVA-331: Add Notification Configuration for BCeID Users * Add basic unit test for Notification list rendering * Looks like duplicate code, maybe got merged with resolve conflicts. Removing it. Need to change this logic completly but this will be part of new PR. * Bump axios from 0.19.2 to 0.21.1 in /.pipeline (#475) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 0.19.2 to 0.21.1 in /.pipeline-v3 (#476) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update patroni health check and liveness check (#480) * ZEVA-369: Fixed Name Associated with the Status History (#478) * Added confirm dialog to reset the validated list * Fixed the government user name being used as part of the alert * Minor label changes/fixes (#483) * ZEVA-376, 379: Send email notification to Analyst and Director based on their subscription for credit transfer. (#482) * adds user prop to supplier tabs and checks permissions before showing tabs (#479) * Only deploy needed apps for test and prod (#486) * only deploy needed apps for test and prod * reduce patroni pod replica for dev * enable rabbitmq-secret-configmap-only.yaml * ZEVA-381: Send notifications to the transfer partner based on thier subscription for credit transfer (#485) * removed navbar link and activity section from bceid users that dont have permissions for sales and transfers (#487) * Automatically clear the error messsage when a new file is selected or when the current file is removed for Credit Applicationss (#484) * Remove openshift v3 and add upload process pod for testing (#488) * remove openshift v3 * add separate upload pod * added condition for displaying credit transaction tab in navbar to idir users (#489) * fixed condition for showing button on transfer modal (#490) * Fix Notification Alerts (#491) * ZEVA-381: Send notifications to the transfer partner based on thier subscription for credit transfer * Fix Notification alerts * Thursday Jan 8 Transfer bugs and changes (#494) * fixed condition for showing button on transfer modal * added disapproved to list of transfers idir users wont see * disabled submit button if there is an unfilled row on transfer form * fixed decimals on table * fixed decimals on total value of transfer for idir * fixed locationstate proptype, added link to transfer details from transaction list table, limited decimals on credit quantity to 0 and credit value to 2 for transfer handlerowinputchange, checked for empty array before displaying error alert for director * Added a command to populate the notification subscription for exiting users. Automatically select all notification subscriptions for new users (#492) * Fixed dashboard not showing the right banner for Approved (#493) * fixed rounding on transfer details table (#495) * Add dashboard red alert for "rejected by transfer partner" option. (#496) * Show Sign off checkboxes only if user has permission to submit the transfer (#497) * ZEVA-406: Dashboard now limits the finalized activities from 28 days to current date (#498) * Dashboard now limits the finalized activities from 28 days to current date * Changed sorting so that the one with changes are in the top * Notification fix (#499) * Restored validate_transfer call (#500) * ZEVA 394 - Vehicle workflow (#502) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * Notification in the front-end is now configurable (#501) * ZEVA 394: Vehicle workflow redirect (#503) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * fixed redirect for saving draft and submitting draft (now both direct to details page) * added else condition for redirecting vehicle details submit * set up compliance front end * zeva 394: Vehicle workflow fix (#504) * changed redirect on saving vehicle model draft (now goes to details page), added submit button to details page action bar * changed submit button on vehicle model form so it redirects to details page * fixed redirect for saving draft and submitting draft (now both direct to details page) * added else condition for redirecting vehicle details submit * set loading to false after vehicle status change * ZEVA-396: Fixed Filter for ICBC Verification Page (#505) * Fixed some of the filters * Fixed filtering for the vin list * Removed commented out code * Removed unused code * Fixed the reload by pushing a route to list then replacing it (#507) * added compliance to navbar, added compliance tabs and containers for the 3 main pages (sales, reports ratios) and details pages for each Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add send notification functionality for credit application. (#512) * ZEVA-372, 410: Fixed filtering for recorded transfers (#506) * Update to release 1.17.0 * changed comments to be associated with history instead of transfer id (#465) * ZEVA 358 - Director reject comment (#461) * Update package.json * remove .yo-rc.json-v4 (#421) * ZEVA-356: Partial fix (#422) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * ZEVA 339 - Disclaimer text (#416) * added disclaimer to every page for bceid users * changed min height for main * removed extra line * Zeva 348 part 1 (#418) * Index optimization * Fixed an issue where the upload date is missing and the icbc vehicle * Added some indexing as well as temporarily disabled some calls * More scaling down * Restored records count * Restored warnings call * Restoring the count call * Testing out a more simple call for fetching the total credits * Optimizing the call for the total credits * Optimizing the call for the total credits * Changing how the calculation works * Rewrote the get totals function for the list view * Disabling details for now * Changing how the content is being read * Temporarily removing the call to warnings * Get warnings function * Code to look for mismatched vins * Changed logic on how to find invalid vehicle models * More vehicle refactoring * Fixed a bug with the year comparison * Rewriting the check for awarded vins * Different way of finding duplicates * Enabled all the checks * Finishing up the initial rework * Fixing totals * Fixed the summary section * Additional check so front-end doesn't crash * Updated invalid submission detection * Changed the alert so it shows the ineligible rows as opposed to unselected * Restoring some of the old functionality to see if it impacts performance * Removed commented out code * Openshift v4 migration (#404) * Zeva 325: BCEID Organization Administrator (#413) * ZEVA-325: Disable controls if BCeId user editing their own profile and are organization admin. * Add permissions to the role serializer and change conditions from roleCode to permissionCode. * Fixed test fixtures (#419) Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> * Add email service (#425) * added tests for transfers (Emily's PR) (#423) * update to v1.15.0 * Operational Scripts Order (#405) * Added sort to ensure the order of the scripts that get loaded * Removed unnecessary conversion to int * ZEVA-336: Backend changes for calculating insufficient credit. (#406) * Zeva 344 (#408) * Add validation status "Rejected" to the condition to display comment for bceId and gov. * BugFix: Display comment when status is CHANGES_REQUESTED for BCeId user. * fix spacing * Zeva 329: Signing Confirmations (#407) * update to v1.14.0 * Changed upload technique for icbc to do chunk uploads (#381) * update version to be v1.13.0 * ZEVA-304: Credits in the Organizations Table (#363) * Added credits to the organization table. Some minor changes * Removed commented out css * Removed console.log * Updated error codes and highlighting of rows (#364) * ZEVA 192 - credit transfer other supplier accepts/rejects (#366) * refactored button story * set up front end to resemble transfer mockup with comment box and checkboxes * set up backend to post new validation status of transfer to database * added model for comments * added comment table, updated frontend so comments can now be posted * added conditions to render checkboxes, comments, and action bar * fixed styling on table, added condition to only show checkboxes if status is submitted, fixed prop type error for submission * wrote tests for transfer details page * replaced text -government- with Government of B.C. (#367) * added 2021 fixture (#368) * edited save function and form fields so that only credit seller can initiate transfer (#369) * ZEVA 292: Update Roles and Permissions (#370) * Updated roles and permissions * Fixed fixture name conflict * Added back with state saving to the vehicle supplier pages (#373) * ZEVA 307 - add optional company/attorney (#371) * added representative name to database in organization address, added field to form on frontent * styled organization edit form * Added check for the validate and reject functions to show up (#374) * Changed upload technique for icbc to do chunk uploads * Added error catching * Removing the autodelete functionality for now * Increased timeout for gunicorn * More debugging * More debugging * Further increased timeout * Increased timeout to 10 mins * Removing the delete function for now: * Adding loggin * Moving the logging up * Fixed indentation * Changing the test logs * Tried chunking the dataframe * Optimizing the read_csv * reworked the uploader and parser * Moved the save date to before the processing of the spreadsheet * Turning off autocommit for the ingest function * Removing transaction auto commit false * Change to using transaction atomic * Testing without transactions * Set autocommit back. Temporarily put back the icbc date loop * Changed the date creation to get_or_create so it doesnt create too many records * Changed so that insert goes at first, and we just do a get after * Code cleanup * Trying out a higher chunk size for uploading Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Signing Assertion models * Work in progress * Work in progress * Checkbox functions * Should now be saving the confirmations from the users Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: Emily <[email protected]> * Added condition to routes and dashboard entries to hide credit transfers when theyre not enabled (#409) * ZEVA 193 - Director approves transfer (#412) * updated frontend to allow director to validate transfer, added service to add credit transaction records and update balances of each supplier * added new dictionary without years to transfer service for updating balance * fixed supplier summary table to use float instead of string and removed dollar value from amount * fixed conflicts, fixed serializer so non government users see approved by transfer partner instead of recommended * updated date field in sales submission to show submission date if the current status is government-altered ie recommended or checked (#414) * added buyer and seller columns to transfer list table (#415) * added tests for transfers Co-authored-by: Kuan Fan <[email protected]> Co-authored-by: NavpreetGrewal <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: emi-hi <[email protected]> * Remove older email (#426) * update patroni pvc size (#428) * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * Update package.json to 1.16.0 * ZEVA-356: Transfer error (#427) * removed balance calculations from frontend, added serializer method field for transfer balance check for analyst * added check for negative balance for analyst, adding check for draft for transfers * finished transfer draft--will now give 400 error if not enough credits for draft or submitted * changed services for director transfesr so it uses aggregate credit function instead of aggregate transfers to find total balance * added catch for submitting new and draft transfers--will now display alert if supplier does not have enough * modified transfer total to diplat only 2 decimals in form * added axios call to retrieve icbc upload date and replaced hard coded date with that response, added alert class for icbc data so correct alert is now showing after upload (#429) * Zeva 313 (#430) * ZEVA-313: Added CHES API intgartion and send email to IDIR users for credit transfer. * Remove SMTP related settings * Remove roleCode related logic and remove pandas import * Remove extra imports * Minor front-end changes (#432) * Added sorting of roles (#433) * Added permission check for the credit transaction tab (#434) * ZEVA-363: Fix Permission Checks for Admin (#438) * Fixed some permission errors so that admin users dont get a no permission error when going to the dashboard * Fixed create user so it keeps track of the username * Zeva 343:Display "New User" button and make user list clickable only if user is admin inside Vehicle supplier/users tab (#437) * ZEVA-343: Display "New User" button and make user list clickbale only if user is admin inside Vehicle supplier/users tab. * Add permission "VIEW_USERS" for Engineer/Analyst role. * Rename fixture to avoid conflict * ZEVA-360: Credit Transfer Rescind Option (#439) * added rescind button to button component and action bar * added new transfer status and updated conditions for rescind button on transfer details page * added redirect for attempting to edit transfers not in draft or rescind form (or user not with initiating supplier), fixed conditions for displaying rescind buttons * added signed by information to details page for bceid users, displaying only initiating supplier date if unsigned by partner * updated logic for displaying signed and submitted information so that if a transfer is rescinded it only shows the signed dates after the rescind date * added rescinded transfers to transfer list for receiving suppliers and added total value text to all details pages under table * Update patroni pvc size and add redirect image (#435) * update Jenkinsfile (#447) * fix Jenkinsfile (#448) * fix jenkinsfile v3 (#449) * Removed duplicate loading (#450) * ZEVA-364: Director role update and also minor change for send_email. (#446) * added disapproved status to transfer list for bceid --so they can see anything that has been rejected by partner or them (#453) * frontend tests (#451) * fixed alert (credits) story * fixed condition in transfer details page for confirmation flag to be set to false if transfer hasn't ever been approved and added history to test * added tests for transfer details and moved signed information out of encompassing div and into seperate divs for submission and approved …
* Added adjustments saving * Removed print
* ZEVA-592: Summary page bugs * Add credit deficit and reduction values to the summary page * minor change * REmove unused code
* ZEVA-545: Update status of report from submitted to recommended * REmove commentd out code
* Added adjustments saving * Removed print * Added delete and load function
* -directs gov user straight to assessment page when report clicked * -adds check for how components display to director -adds button to issue assessment or return to analyst * -changes comment title when director is making comment, adds check for disabling radio buttons for a/b credits
* ZEVA-545: Update status of report from submitted to recommended * REmove commentd out code * Disable recommend button if pending sales exist
* ZEVA-545: Update status of report from submitted to recommended * REmove commentd out code * Disable recommend button if pending sales exist * Add tooltip and allow analyst to edit consumer zev sales if pending sales exist * ZEVA-607: Vehicle Supplier - Bugs * ZEVA-608 : Model Year Report Consumer Sales Bugs
* Fixed bugs with the Supplier Information * Fixed a bug with the supplier class
* adds deficit and compliance flag to serializer * adds extra condition for how decision is shown to bceid to avoid errors * -adds in compliance flag and red background to closing and opening balance * -adds model year to serializer, adds prior year deficit * -adds logic for getting prior year report and assessment * -adds creation of assessment object in model year report viewset * -fixes frontend so penalty and decision get passed to database correctly and moves those states into details, removing the seperate states (penalty and radioSelection) -fixes how deficit is organized in modelYearReportAssessmentSerializer * -adds report year and prior year keys to in compliance (is now a dictionary) so boolean is specific to year -adds starting and closing balances to assessment details (will show EITHER the balance OR the deficit amount) * removes commented out code
|
SonarCloud Quality Gate failed.
|
* ZEVA-545: Update status of report from submitted to recommended * REmove commentd out code * Disable recommend button if pending sales exist * Add tooltip and allow analyst to edit consumer zev sales if pending sales exist * ZEVA-607: Vehicle Supplier - Bugs * ZEVA-608 : Model Year Report Consumer Sales Bugs * Fix for consumer sales bug
* adds condition for rendering assessment decision description * -sets modelyear to correct year in assessment container * -adds check before rendering credit activity box -moves code for deficit so it is passed with assessment even if no assment record exists yet * -changes some variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.