Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICBC Upload Fix #959

Merged
merged 2 commits into from
Nov 30, 2021
Merged

ICBC Upload Fix #959

merged 2 commits into from
Nov 30, 2021

Conversation

amichard
Copy link
Contributor

Changelog:

  • Header Names are now adjusted to be uppercase (internally)
  • Changed how the csv is being read

@amichard amichard self-assigned this Nov 29, 2021
@amichard amichard merged commit 2e29be3 into bcgov:release-1.34.0 Nov 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

amichard added a commit that referenced this pull request Dec 14, 2021
* update to 1.34.0

* CTHUB-100: Cleaned Up Supplemental Report History (#955)

* Reduced the noise for the text in compliance history

* Removed commented out code

* Added tabs for switching between supplementary vs reassessment (#956)

* CTHUB-97: ZEVA - Allow IDIR user to edit MY2017-2019 sales figures (#957)

* Allowed updating of icbc data upon upload (#958)

* ICBC Upload Fix (#959)

* Changed how the csv is being read

* Further performance optimization

* Fix upload icbc performance (#960)

* Changed how the csv is being read

* Further performance optimization

* Added keep alive function back

* Increased worker timeout (#962)

* Changed how the csv is being read

* Further performance optimization

* Added keep alive function back

* Increased worker timeout

* ZEVA - Rejected credit applications refinements (#961)

* add metabase user (#963)

* Fix upload icbc (#964)

* Changed how the csv is being read

* Further performance optimization

* Added keep alive function back

* Increased worker timeout

* Restored the previous way of filtering electic vehicles

* Fixed various bugs (#965)

* Fixed issue where submitted gets overridden by government user (#966)

* Changed how Supplementary/Reassessment workflow

Co-authored-by: Kuan Fan <[email protected]>
Co-authored-by: NavpreetGrewal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants