-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArgumentOfRangeException when inserting objects with DateTime.MinValue #66
Comments
Hi, thanks for the report; however, I cannot help without more context information. Preferably,
Maybe related to #49 Thanks, |
Also, labeled this as kind of gotcha since RethinkDB doesn't support a datetimes with |
Hi Brian Sorry for the lack of detail. Here is a test and a stacktrace. Time is Unix time or Epoch and DateTime.MinValue works fine with this. It simply becomes a rather large negative number. More precisely this -62135596800 :) Unit test
Stacktrace
|
Hi @ThomasHoest , Unfortunately, I _cannot_ reproduce the error with your unit test.
Still need more information:
Also, FWIW, as guidance, I would not recommend using Lastly, it's a holiday weekend here in the USA so I won't be available much. I'd prefer to keep issues related to source code changes, confirmed bugs, and features requests. Every time an issue is created 12 people get slammed on the repo watch list. 😿 If you need additional help, you can PM me on slack via BBQ time. Thanks, 🙌 👴 _"A pair of hard working hands. Everything that I needed. I got it from the old man..."_ |
Hi Thomas, I've changed up the Basically, I've shunted the
Thanks, |
Hi Brian Thanks for letting me know I will give the new version a test. A note on the previous test. It fails when have set my timezone to UTC+2 the test succeeds when i have it set to UTC-7 (which I assume is yours). Thanks, |
@ThomasHoest Ah, that's probably it then. Maybe Let me know how it goes. Don't forget to hit the close button with vengeance if your unit test passes! Thanks, |
Hola Thomas, Hope you are doing well. It's been a few days, so I'm going to close the issue but if you still encounter any problems, please feel free to reach out on slack / @bchavez or re-open the issue if the problem persists. Tak, |
It seems that the ReqlDateTimeConverter throws an exception when converting DateTime.MinValue. Seems converting non UTC results can result in this. Converting like this
dto = DateTime.SpecifyKind((DateTime)value,DateTimeKind.Utc);
prevents it, but wouldn't work for dates saved in local time. Digging deeper and perhaps i can come up with some more detail.
The text was updated successfully, but these errors were encountered: