Fixes several issues that broke the testing workflow #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcao-bdai
requested review from
petercorke,
jhavl and
myeatman-bdai
as code owners
jcao-bdai
changed the title
bhung-bdai
approved these changes
Jul 22, 2024
| # ax.plot(E[0], E[1], E[2], **kwargs) | ||
| lines.append(E.T) | ||
| for line in zip(edge[:-1], edge[1:]): | ||
| E = vertices[:, line] |
There was a problem hiding this comment.
I feel like I learn new weird Python hacks every time I read stuff like this.
jcao-bdai
changed the title
myeatman-bdai
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues that broke the testing workflow:
add_collection3dnow requires items in_segments3dto have homogeneous shapes (breaking change introduced by matplotlib and numpy).