Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use universal binary for macOS #272

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Use universal binary for macOS #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fd2f3a
Use universal binary for macOS
morishin Jun 14, 2024
4558afa
Specify singleArchFiles
morishin Jun 14, 2024
4999405
Use notarytool explicitly
morishin Jun 14, 2024
fa7a286
Fix property name
morishin Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ win:
- nsis

mac:
singleArchFiles: "*"
target:
- zip
- dmg
- target: dmg
arch: universal
- target: zip
arch: universal
category: public.app-category.developer-tools
hardenedRuntime: true
entitlements: ./build/entitlement.plist
Expand Down
5 changes: 3 additions & 2 deletions scripts/notarize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = async function () {
return;
}

const appPath = path.resolve(__dirname, "../dist/production/mac/Bdash.app");
const appPath = path.resolve(__dirname, "../dist/production/mac-universal/Bdash.app");

if (!fs.existsSync(appPath)) {
throw new Error(`Cannot find application at: ${appPath}`);
Expand All @@ -16,11 +16,12 @@ module.exports = async function () {
console.log("afterSign: Notarizing");

await notarize({
tool: "notarytool",
appBundleId: "io.bdash",
appPath: appPath,
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_PASSWORD,
ascProvider: process.env.ASC_PROVIDER,
teamId: process.env.ASC_PROVIDER,
});

console.log("afterSign: Notarized");
Expand Down
Loading