Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow pubnub unsub to complete since nothing currently waits #114

Merged
merged 1 commit into from
Jun 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions yalexs/pubnub_async.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Connect to pubnub."""

import asyncio
import datetime
import logging
from collections.abc import Coroutine
Expand Down Expand Up @@ -126,6 +127,9 @@ def async_create_pubnub(
async def _async_unsub():
_LOGGER.debug("Removing listeners PubNub")
pubnub.remove_listener(subscriptions)
_LOGGER.debug("Unsubscribing from PubNub")
pubnub.unsubscribe_all()
await asyncio.sleep(0.1) # Allow the unsubscribe to complete
_LOGGER.debug("Stopping PubNub")
await pubnub.stop()
_LOGGER.debug("PubNub stopped")
Expand Down
Loading