-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more activity types #87
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 95.56% 95.62% +0.05%
==========================================
Files 29 29
Lines 3316 3357 +41
==========================================
+ Hits 3169 3210 +41
Misses 147 147
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@cached_property | ||
def operated_manual(self): | ||
"""Operation done manually using the knob.""" | ||
return self._info.get("manual", self.action in MANUAL_ACTIONS) | ||
|
||
@cached_property | ||
def operated_tag(self): | ||
"""Operation used rfid tag.""" | ||
return self._info.get("tag", self.action in TAG_ACTIONS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is only hitting coverage from the repr
, we should have an explicit test for both of these to make sure its true when its operated by the knob/tag
You should be able to augment Line 272 in 4ea45b2
|
Fix #86 Did not add BT-methods as I don't use them, and they break yalexs-bt in HA when I test them. |
This adds support for manual lock/unlock and unlock using rfid-tags:
Example activities:
Manual lock
Notice
operated_manual=True
Manual unlock
Notice
operated_manual=True
Tag unlock
Notice
operated_tag=True