Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Type Piece U+1CE3B is wrong #2206

Closed
PhMajerus opened this issue Feb 21, 2024 · 3 comments
Closed

Large Type Piece U+1CE3B is wrong #2206

PhMajerus opened this issue Feb 21, 2024 · 3 comments
Labels

Comments

@PhMajerus
Copy link

  • Your font version: 28.1.0; ttfautohint (v1.8.4) from PkgTTC-Iosevka-28.1.0.zip
  • Your font variant: Regular
  • Your operating system (name and version): Win11 Pro x64 en-us
  • Your application using Iosevka: Windows Terminal

Good job on including the Large Type Pieces, I've been experimenting with them as well and read through Unicode and original HP 2640 Series reference manual.

I noticed one of the piece is wrong, U+1CE3B is supposed to be the upper left diagonal piece:
image
image
(From Unicode's 21235r-terminals-supplement.pdf)

It is mirrored and top-aligned in your font.
You can easily create that character from your correct upper left and lower left U+1CE38, as it contains both the upper left (U+1CE3B) and lower left (U+1CE22) diagonals combined.

Here's the original HP 2640 Series reference chart using your font:
image

Every other piece seems correct, only occurrences of U+1CE3B are breaking the large characters.

For comparison, you can see the same chart using my glyphs here: microsoft/cascadia-code#709

@be5invis
Copy link
Owner

@PhMajerus What's the program you used to demonstrate?

@be5invis
Copy link
Owner

@Logo121 FYI

@PhMajerus
Copy link
Author

PhMajerus commented Feb 21, 2024

@be5invis
It's just a text file displayed in Windows Terminal using cat.
I plan to post it in some repository later, and still need to review it a bit, but if you want it to test your font, here the current copy of my documentation file:
Edit: Removed embedded HowTo Large Type Pieces.txt file, now available using curl https://raw.githubusercontent.com/PhMajerus/Documents/main/HowTos/HowTo%20Large%20Type%20Pieces.txt.

It describes all the history and how to use the large type pieces.

I also have a FIGlet font to easily generate large text using the large type pieces almost ready.
Edit: My FIGfont phm-largetype is now available in my FIGfonts collection

be5invis added a commit that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants