Add message handling for when image build fails to pull and archive initial image #565
Conversation
|
|
||
| _, err = b.containerRepo.GetContainerExitCode(containerId) | ||
| if err == nil { | ||
| outputChan <- common.OutputMsg{Done: true, Success: false, Msg: "Base image failed to load.\n"} |
There was a problem hiding this comment.
I think we need to check if the exit code is > 0 because it looks like terminateContainer() calls SetContainerExitCode(). We also pass a reference of the exit code to terminateContainer(), which can be set from s.runcHandle.Run().
| // a container address for the runc client to connect to. | ||
| // If it fails without a container address, we can still look up the exit code | ||
| // to terminate the build and notify the user. | ||
| for { |
There was a problem hiding this comment.
We might want to pass the calling function's context and check to see if its done using a select{} in the for loop. Doing this should guarantee that if someone disconnects or hits Ctl-C, this will exit regardless whats happening in the build workers.
| @@ -199,6 +199,9 @@ func (b *Builder) Build(ctx context.Context, opts *BuildOpts, outputChan chan co | |||
| return err | |||
| } | |||
|
|
|||
| // Get the hostname of the build container | |||
| go b.checkForInitialImagePullError(containerId, outputChan) | |||
There was a problem hiding this comment.
I think we can probably do this without an extra goroutine
There was a problem hiding this comment.
Ideally I check in the gateway to see if the image exists or not. But the packages that help do this require a shitton of other packages
There was a problem hiding this comment.
@jsun-m Is this still required with the inspect and verify stuff now?
No description provided.