Query servers in parallel in dns_query input (influxdata#4754)

bearstech · Apr 17, 2020 · e44c41d · e44c41d
1 parent f62eeaf
commit e44c41d
Showing 1 changed file with 25 additions and 19 deletions.
diff --git a/plugins/inputs/dns_query/dns_query.go b/plugins/inputs/dns_query/dns_query.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"net"
 	"strconv"
+	"sync"
 	"time"
 
 	"github.com/miekg/dns"
@@ -70,32 +71,37 @@ func (d *DnsQuery) Description() string {
 	return "Query given DNS server and gives statistics"
 }
 func (d *DnsQuery) Gather(acc telegraf.Accumulator) error {
+	var wg sync.WaitGroup
 	d.setDefaultValues()
 
 	for _, domain := range d.Domains {
 		for _, server := range d.Servers {
-			fields := make(map[string]interface{}, 2)
-			tags := map[string]string{
-				"server":      server,
-				"domain":      domain,
-				"record_type": d.RecordType,
-			}
-
-			dnsQueryTime, err := d.getDnsQueryTime(domain, server)
-			if err == nil {
-				setResult(Success, fields, tags)
-				fields["query_time_ms"] = dnsQueryTime
-			} else if opErr, ok := err.(*net.OpError); ok && opErr.Timeout() {
-				setResult(Timeout, fields, tags)
-			} else if err != nil {
-				setResult(Error, fields, tags)
-				acc.AddError(err)
-			}
-
-			acc.AddFields("dns_query", fields, tags)
+			wg.Add(1)
+			go func(domain, server string) {
+				fields := make(map[string]interface{}, 2)
+				tags := map[string]string{
+					"server":      server,
+					"domain":      domain,
+					"record_type": d.RecordType,
+				}
+
+				dnsQueryTime, err := d.getDnsQueryTime(domain, server)
+				if err == nil {
+					setResult(Success, fields, tags)
+					fields["query_time_ms"] = dnsQueryTime
+				} else if opErr, ok := err.(*net.OpError); ok && opErr.Timeout() {
+					setResult(Timeout, fields, tags)
+				} else if err != nil {
+					setResult(Error, fields, tags)
+					acc.AddError(err)
+				}
+
+				acc.AddFields("dns_query", fields, tags)
+			}(domain, server)
 		}
 	}
 
+	wg.Wait()
 	return nil
 }