Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi database support for pending migration error #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

beauraF
Copy link
Owner

@beauraF beauraF commented May 29, 2024

Motivation / Background

PendingMigrationError actionable error currently does not support a multi database setup. The goal of this PR is to add support for multi database setup.

Detail

I have chosen to directly invoke the db:migrate rake task in the action, so any code change to the migrate task will be reflected. But I'm really unsure about this implementation, as it require to Rails.application.load_tasks and I can't find any similar pattern anywhere in the codebase.

Checklist

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Add PendingMigrationError actionable error multi database support
by directly invoking the db:migrate rake task in the action.
@beauraF beauraF force-pushed the add-multi-database-support-for-pending-migration-error branch from 4a116ac to caa7aae Compare May 29, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant